Change SQLDatabaseConnectionImpl#synchronizeModel behaviour

Author: ZorTik

api/src/main/java/me/zort/sqllib/api/data/QueryResult.java

@@ -13,6 +13,8 @@ public interface QueryResult {
     @Nullable
     String getRejectMessage();
 
+    QueryResult noChangesResult = successful();
+
     static QueryResult successful() {
         return new QueryResult() {
             @Override

core/src/main/java/me/zort/sqllib/SQLDatabaseConnectionImpl.java

@@ -183,7 +183,7 @@ public void enableCaching(CacheManager cacheManager) {
      * <i>Warning:</i> This tries to update all tables that are part of mapping
      * proxies. Should be used carefully.
      *
-     * @return True if synchronization was successful
+     * @return True if there were any changes
      */
     @ApiStatus.Experimental
     @Override
@@ -192,7 +192,7 @@ public boolean synchronizeModel() {
                 .stream().flatMap(i -> i.getTableSchemas(
                         getOptions().getNamingStrategy(),
                         this instanceof SQLiteDatabaseConnectionImpl).stream())
-                .allMatch(schema -> synchronizeModel(schema, schema.getTable()));
+                .anyMatch(schema -> synchronizeModel(schema, schema.getTable()));
     }
 
     /**
@@ -202,13 +202,14 @@ public boolean synchronizeModel() {
      *
      * @param entitySchema Entity schema
      * @param table Table name
-     * @return True if synchronization was successful
+     * @return True if there were any changes
      */
     @ApiStatus.Experimental
     @Override
     public boolean synchronizeModel(TableSchema entitySchema, String table) {
-        return getSchemaSynchronizer().synchronize(this, entitySchema,
-                getSchemaBuilder(table).buildTableSchema()).isSuccessful();
+        QueryResult result = getSchemaSynchronizer().synchronize(this, entitySchema,
+                getSchemaBuilder(table).buildTableSchema());
+        return result != QueryResult.noChangesResult && result.isSuccessful();
     }
 
     /**
@@ -219,7 +220,7 @@ public boolean synchronizeModel(TableSchema entitySchema, String table) {
      *
      * @param entity The entity (model) class
      * @param table Table name
-     * @return True if synchronization was successful
+     * @return True if there were any changes
      */
     @ApiStatus.Experimental
     @Override

core/src/main/java/me/zort/sqllib/model/SQLSchemaSynchronizer.java

@@ -27,6 +27,6 @@ public QueryResult synchronize(SQLDatabaseConnection source, TableSchema from, T
                 }
             }
         }
-        return query.length() == 0 ? QueryResult.successful() : source.exec(query.toString());
+        return query.length() == 0 ? QueryResult.noChangesResult : source.exec(query.toString());
     }
 }

src/test/java/me/zort/sqllib/test/TestCase2.java

@@ -83,8 +83,8 @@ public void test2_Synchronization() {
         assertEquals(2, dbSchema.getDefinitions().length);
         assertEquals("nickname VARCHAR(255) PRIMARY KEY", dbSchema.getDefinitions()[0]);
         assertEquals("points INTEGER", dbSchema.getDefinitions()[1]);
-        assertTrue(connection.synchronizeModel(schema, "users"));
-        assertTrue(connection.synchronizeModel());
+        assertFalse(connection.synchronizeModel(schema, "users"));
+        assertFalse(connection.synchronizeModel());
     }
 
     @Timeout(5)