Fixed logSqlErrors setting not effective.

Author: ZorTik

api/src/main/java/me/zort/sqllib/api/SQLConnection.java

@@ -2,7 +2,6 @@
 
 import org.jetbrains.annotations.Nullable;
 
-import java.io.Closeable;
 import java.sql.Connection;
 
 /**
@@ -12,8 +11,7 @@
  *
  * @author ZorTik
  */
-@SuppressWarnings("closeable")
-public interface SQLConnection extends Closeable {
+public interface SQLConnection {
 
     /**
      * Tries to connect to remote SQL server.
@@ -26,9 +24,7 @@ public interface SQLConnection extends Closeable {
     /**
      * Tries to disconnect from remote SQL server.
      */
-    @Deprecated
     void disconnect();
-    void close();
 
     /**
      * Returns current running connection with

core/src/main/java/me/zort/sqllib/SQLConnectionBuilder.java

@@ -15,7 +15,6 @@
 import java.sql.DriverManager;
 import java.sql.SQLException;
 import java.util.Objects;
-import java.util.Optional;
 
 public final class SQLConnectionBuilder implements Cloneable {
 
@@ -113,7 +112,7 @@ public static class BuilderSQLConnectionFactory implements SQLConnectionFactory
 
         @Nullable
         @Override
-        public Connection connect() {
+        public Connection connect() throws SQLException {
             try {
                 Class.forName(driver);
             } catch (ClassNotFoundException e) {
@@ -122,12 +121,7 @@ public Connection connect() {
             String jdbc = builder.jdbc;
             String usr = builder.endpoint.getUsername();
             String pwd = builder.endpoint.getPassword();
-            try {
-                return DriverManager.getConnection(jdbc, usr, pwd);
-            } catch (SQLException e) {
-                e.printStackTrace();
-                return null;
-            }
+            return DriverManager.getConnection(jdbc, usr, pwd);
         }
 
     }

core/src/main/java/me/zort/sqllib/SQLDatabaseConnection.java

@@ -11,6 +11,7 @@
 import org.jetbrains.annotations.ApiStatus;
 import org.jetbrains.annotations.Nullable;
 
+import java.io.Closeable;
 import java.sql.Connection;
 import java.sql.SQLException;
 
@@ -21,7 +22,7 @@
  * @author ZorTik
  */
 @SuppressWarnings("unused")
-public abstract class SQLDatabaseConnection implements SQLConnection {
+public abstract class SQLDatabaseConnection implements SQLConnection, Closeable {
 
     private final SQLConnectionFactory connectionFactory;
     @Getter(onMethod_ = {@Nullable})

core/src/main/java/me/zort/sqllib/SQLDatabaseConnectionImpl.java

@@ -263,10 +263,10 @@ public <T> QueryRowsResult<T> query(Query query, Class<T> typeClass) {
      */
     @Override
     public QueryRowsResult<Row> query(Query query) {
-        return doQuery(query, false);
+        return query(query, false);
     }
 
-    private QueryRowsResult<Row> doQuery(Query query, boolean isRetry) {
+    private QueryRowsResult<Row> query(Query query, boolean isRetry) {
         Objects.requireNonNull(query);
 
         if(!handleAutoReconnect()) {
@@ -294,7 +294,7 @@ private QueryRowsResult<Row> doQuery(Query query, boolean isRetry) {
         } catch (SQLException e) {
             if (!isRetry && e.getMessage().contains("database connection closed")) {
                 reconnect();
-                return doQuery(query, true);
+                return query(query, true);
             }
 
             logSqlError(e);
@@ -314,10 +314,10 @@ private QueryRowsResult<Row> doQuery(Query query, boolean isRetry) {
      * about success state of the request.
      */
     public QueryResult exec(Query query) {
-        return doExec(query, false);
+        return exec(query, false);
     }
 
-    private QueryResult doExec(Query query, boolean isRetry) {
+    private QueryResult exec(Query query, boolean isRetry) {
         if(!handleAutoReconnect()) {
             return new QueryResultImpl(false, "Cannot connect to database!");
         }
@@ -327,7 +327,7 @@ private QueryResult doExec(Query query, boolean isRetry) {
         } catch (SQLException e) {
             if (!isRetry && e.getMessage().contains("database connection closed")) {
                 reconnect();
-                return doExec(query, true);
+                return exec(query, true);
             }
 
             logSqlError(e);
@@ -359,9 +359,7 @@ public QueryResult save(String table, Object obj) { // by default, it creates an
 
     public QueryResult insert(String table, Object obj) {
         Pair<String[], UnknownValueWrapper[]> data = buildDefsVals(obj);
-
-        if (data == null)
-            return new QueryResultImpl(false);
+        if (data == null) return new QueryResultImpl(false);
 
         InsertQuery query = insert().into(table, data.getFirst());
         for (UnknownValueWrapper valueWrapper : data.getSecond()) {

core/src/main/java/me/zort/sqllib/pool/PooledSQLDatabaseConnection.java

@@ -5,7 +5,9 @@
 import me.zort.sqllib.internal.factory.SQLConnectionFactory;
 import org.jetbrains.annotations.Nullable;
 
-public abstract class PooledSQLDatabaseConnection extends SQLDatabaseConnection {
+import java.io.Closeable;
+
+public abstract class PooledSQLDatabaseConnection extends SQLDatabaseConnection implements Closeable {
 
     private SQLConnectionPool assignedPool = null;
     @Getter(onMethod_ = {@Nullable})

src/test/java/me/zort/sqllib/test/TestCase1.java

@@ -170,6 +170,7 @@ public void test6_Pool() {
         assertEquals(0, pool.size());
     }
 
+
     @Timeout(5)
     @Test
     public void test7_Close() {