chore: fix CI/CD linter and type check errors

muscariello · muscariello · commit 3d01f33f6e92 · 2026-02-02T22:24:47.000+01:00
Signed-off-by: Luca Muscariello &lt;muscariello@ieee.org&gt;
diff --git a/src/a2a/client/base_client.py b/src/a2a/client/base_client.py
@@ -14,12 +14,12 @@
 from a2a.types.a2a_pb2 import (
     AgentCard,
     CancelTaskRequest,
+    CreateTaskPushNotificationConfigRequest,
     GetTaskPushNotificationConfigRequest,
     GetTaskRequest,
     Message,
     SendMessageConfiguration,
     SendMessageRequest,
-    CreateTaskPushNotificationConfigRequest,
     StreamResponse,
     SubscribeToTaskRequest,
     Task,
diff --git a/src/a2a/client/client.py b/src/a2a/client/client.py
@@ -12,11 +12,11 @@
 from a2a.types.a2a_pb2 import (
     AgentCard,
     CancelTaskRequest,
+    CreateTaskPushNotificationConfigRequest,
     GetTaskPushNotificationConfigRequest,
     GetTaskRequest,
     Message,
     PushNotificationConfig,
-    CreateTaskPushNotificationConfigRequest,
     StreamResponse,
     SubscribeToTaskRequest,
     Task,
diff --git a/src/a2a/client/client_factory.py b/src/a2a/client/client_factory.py
@@ -282,5 +282,4 @@ def minimal_agent_card(
         skills=[],
         version='',
         name='',
-
-        )
+    )
diff --git a/src/a2a/client/transports/base.py b/src/a2a/client/transports/base.py
@@ -5,11 +5,11 @@
 from a2a.types.a2a_pb2 import (
     AgentCard,
     CancelTaskRequest,
+    CreateTaskPushNotificationConfigRequest,
     GetTaskPushNotificationConfigRequest,
     GetTaskRequest,
     SendMessageRequest,
     SendMessageResponse,
-    CreateTaskPushNotificationConfigRequest,
     StreamResponse,
     SubscribeToTaskRequest,
     Task,
diff --git a/src/a2a/server/apps/jsonrpc/jsonrpc_app.py b/src/a2a/server/apps/jsonrpc/jsonrpc_app.py
@@ -24,6 +24,7 @@
     InvalidParamsError,
     InvalidRequestError,
     JSONParseError,
+    JSONRPCError,
     MethodNotFoundError,
 )
 from a2a.server.request_handlers.jsonrpc_handler import JSONRPCHandler
@@ -49,6 +50,7 @@
     PREV_AGENT_CARD_WELL_KNOWN_PATH,
 )
 from a2a.utils.errors import (
+    A2AException,
     MethodNotImplementedError,
     UnsupportedOperationError,
 )
@@ -225,7 +227,9 @@ def __init__(  # noqa: PLR0913
         self._max_content_length = max_content_length
 
     def _generate_error_response(
-        self, request_id: str | int | None, error: Exception
+        self,
+        request_id: str | int | None,
+        error: Exception | JSONRPCError | A2AException,
     ) -> JSONResponse:
         """Creates a Starlette JSONResponse for a JSON-RPC error.
 
@@ -238,6 +242,9 @@ def _generate_error_response(
         Returns:
             A `JSONResponse` object formatted as a JSON-RPC error response.
         """
+        if not isinstance(error, (A2AException, JSONRPCError)):
+            error = InternalError(message=str(error))
+
         response_data = build_error_response(request_id, error)
         error_info = response_data.get('error', {})
         code = error_info.get('code')
diff --git a/src/a2a/server/request_handlers/default_request_handler.py b/src/a2a/server/request_handlers/default_request_handler.py
@@ -38,7 +38,6 @@
     Message,
     PushNotificationConfig,
     SendMessageRequest,
-    StreamResponse,
     SubscribeToTaskRequest,
     Task,
     TaskPushNotificationConfig,
@@ -541,7 +540,7 @@ async def on_subscribe_to_task(
         self,
         params: SubscribeToTaskRequest,
         context: ServerCallContext | None = None,
-    ) -> AsyncGenerator[StreamResponse]:
+    ) -> AsyncGenerator[Event, None]:
         """Default handler for 'SubscribeToTask'.
 
         Allows a client to re-attach to a running streaming task's event stream.
diff --git a/src/a2a/server/request_handlers/jsonrpc_handler.py b/src/a2a/server/request_handlers/jsonrpc_handler.py
@@ -19,6 +19,7 @@
 from a2a.types.a2a_pb2 import (
     AgentCard,
     CancelTaskRequest,
+    CreateTaskPushNotificationConfigRequest,
     DeleteTaskPushNotificationConfigRequest,
     GetExtendedAgentCardRequest,
     GetTaskPushNotificationConfigRequest,
@@ -27,7 +28,6 @@
     Message,
     SendMessageRequest,
     SendMessageResponse,
-    CreateTaskPushNotificationConfigRequest,
     SubscribeToTaskRequest,
     Task,
 )
diff --git a/src/a2a/server/request_handlers/request_handler.py b/src/a2a/server/request_handlers/request_handler.py
@@ -5,14 +5,14 @@
 from a2a.server.events.event_queue import Event
 from a2a.types.a2a_pb2 import (
     CancelTaskRequest,
+    CreateTaskPushNotificationConfigRequest,
     DeleteTaskPushNotificationConfigRequest,
     GetTaskPushNotificationConfigRequest,
     GetTaskRequest,
     ListTaskPushNotificationConfigRequest,
     ListTaskPushNotificationConfigResponse,
     Message,
     SendMessageRequest,
-    CreateTaskPushNotificationConfigRequest,
     SubscribeToTaskRequest,
     Task,
     TaskPushNotificationConfig,
diff --git a/src/a2a/server/request_handlers/response_helpers.py b/src/a2a/server/request_handlers/response_helpers.py
@@ -143,7 +143,7 @@ def prepare_response_object(
             result = MessageToDict(response, preserving_proto_field_name=False)
         return JSONRPC20Response(result=result, _id=request_id).data
 
-    if isinstance(response, _A2A_ERROR_TYPES):
+    if isinstance(response, (A2AException, JSONRPCError)):
         return build_error_response(request_id, response)
 
     # If response is not an expected success type and not an error,
diff --git a/src/a2a/utils/constants.py b/src/a2a/utils/constants.py
@@ -19,3 +19,7 @@ class TransportProtocol:
     jsonrpc = TRANSPORT_JSONRPC
     http_json = TRANSPORT_HTTP_JSON
     grpc = TRANSPORT_GRPC
+
+
+DEFAULT_MAX_CONTENT_LENGTH = 10 * 1024 * 1024  # 10MB
+JSONRPC_PARSE_ERROR_CODE = -32700
diff --git a/src/a2a/utils/error_handlers.py b/src/a2a/utils/error_handlers.py
@@ -2,7 +2,7 @@
 import logging
 
 from collections.abc import Awaitable, Callable, Coroutine
-from typing import TYPE_CHECKING, Any
+from typing import TYPE_CHECKING, Any, cast
 
 
 if TYPE_CHECKING:
@@ -88,7 +88,9 @@ async def wrapper(*args: Any, **kwargs: Any) -> Response:
             error = e.error or InternalError(
                 message='Internal error due to unknown reason'
             )
-            http_code = A2AErrorToHttpStatus.get(type(error), 500)
+            http_code = A2AErrorToHttpStatus.get(
+                cast('_A2AErrorType', type(error)), 500
+            )
 
             log_level = (
                 logging.ERROR
@@ -99,13 +101,14 @@ async def wrapper(*args: Any, **kwargs: Any) -> Response:
                 log_level,
                 "Request error: Code=%s, Message='%s'%s",
                 getattr(error, 'code', 'N/A'),
-                error.message,
+                getattr(error, 'message', str(error)),
                 ', Data=' + str(getattr(error, 'data', ''))
                 if getattr(error, 'data', None)
                 else '',
             )
             return JSONResponse(
-                content={'message': error.message}, status_code=http_code
+                content={'message': getattr(error, 'message', str(error))},
+                status_code=http_code,
             )
         except Exception:
             logger.exception('Unknown error occurred')
@@ -139,7 +142,7 @@ async def wrapper(*args: Any, **kwargs: Any) -> Any:
                 log_level,
                 "Request error: Code=%s, Message='%s'%s",
                 getattr(error, 'code', 'N/A'),
-                error.message,
+                getattr(error, 'message', str(error)),
                 ', Data=' + str(getattr(error, 'data', ''))
                 if getattr(error, 'data', None)
                 else '',
diff --git a/tests/client/test_auth_middleware.py b/tests/client/test_auth_middleware.py
@@ -320,7 +320,9 @@ async def test_auth_interceptor_variants(
         default_output_modes=[],
         skills=[],
         capabilities=AgentCapabilities(),
-        security_requirements=[SecurityRequirement(schemes={test_case.scheme_name: StringList()})],
+        security_requirements=[
+            SecurityRequirement(schemes={test_case.scheme_name: StringList()})
+        ],
         security_schemes={
             test_case.scheme_name: wrap_security_scheme(
                 test_case.security_scheme
@@ -370,7 +372,9 @@ async def test_auth_interceptor_skips_when_scheme_not_in_security_schemes(
         default_output_modes=[],
         skills=[],
         capabilities=AgentCapabilities(),
-        security_requirements=[SecurityRequirement(schemes={scheme_name: StringList()})],
+        security_requirements=[
+            SecurityRequirement(schemes={scheme_name: StringList()})
+        ],
         security_schemes={},
     )
 
diff --git a/tests/client/test_client_task_manager.py b/tests/client/test_client_task_manager.py
@@ -100,7 +100,6 @@ async def test_process_with_status_update(
         status=TaskStatus(
             state=TaskState.TASK_STATE_COMPLETED, message=sample_message
         ),
-        
     )
     status_event = StreamResponse(status_update=status_update)
     updated_task = await task_manager.process(status_event)
@@ -145,7 +144,6 @@ async def test_process_creates_task_if_not_exists_on_status_update(
         task_id='new_task',
         context_id='new_context',
         status=TaskStatus(state=TaskState.TASK_STATE_WORKING),
-        
     )
     status_event = StreamResponse(status_update=status_update)
     updated_task = await task_manager.process(status_event)
diff --git a/tests/extensions/test_common.py b/tests/extensions/test_common.py
@@ -5,7 +5,12 @@
     get_requested_extensions,
     update_extension_header,
 )
-from a2a.types.a2a_pb2 import AgentCapabilities, AgentInterface, AgentCard, AgentExtension
+from a2a.types.a2a_pb2 import (
+    AgentCapabilities,
+    AgentInterface,
+    AgentCard,
+    AgentExtension,
+)
 
 
 def test_get_requested_extensions():
@@ -34,7 +39,9 @@ def test_find_extension_by_uri():
         name='Test Agent',
         description='Test Agent Description',
         version='1.0',
-        supported_interfaces=[AgentInterface(url='http://test.com', protocol_binding='HTTP+JSON')],
+        supported_interfaces=[
+            AgentInterface(url='http://test.com', protocol_binding='HTTP+JSON')
+        ],
         skills=[],
         default_input_modes=['text/plain'],
         default_output_modes=['text/plain'],
@@ -51,7 +58,9 @@ def test_find_extension_by_uri_no_extensions():
         name='Test Agent',
         description='Test Agent Description',
         version='1.0',
-        supported_interfaces=[AgentInterface(url='http://test.com', protocol_binding='HTTP+JSON')],
+        supported_interfaces=[
+            AgentInterface(url='http://test.com', protocol_binding='HTTP+JSON')
+        ],
         skills=[],
         default_input_modes=['text/plain'],
         default_output_modes=['text/plain'],
diff --git a/tests/server/events/test_event_queue.py b/tests/server/events/test_event_queue.py
@@ -112,7 +112,6 @@ async def test_dequeue_event_wait(event_queue: EventQueue) -> None:
         task_id='task_123',
         context_id='session-xyz',
         status=TaskStatus(state=TaskState.TASK_STATE_WORKING),
-        
     )
     await event_queue.enqueue_event(event)
     dequeued_event = await event_queue.dequeue_event()
diff --git a/tests/server/request_handlers/test_default_request_handler.py b/tests/server/request_handlers/test_default_request_handler.py
@@ -2026,10 +2026,7 @@ async def test_get_task_push_notification_config_info_with_config():
 
     assert result is not None
     assert result.task_id == 'task_1'
-    assert (
-        result.push_notification_config.url
-        == set_config_params.config.url
-    )
+    assert result.push_notification_config.url == set_config_params.config.url
     assert result.push_notification_config.id == 'config_id'
 
 
@@ -2068,10 +2065,7 @@ async def test_get_task_push_notification_config_info_with_config_no_id():
 
     assert result is not None
     assert result.task_id == 'task_1'
-    assert (
-        result.push_notification_config.url
-        == set_config_params.config.url
-    )
+    assert result.push_notification_config.url == set_config_params.config.url
     assert result.push_notification_config.id == 'task_1'
 
 
diff --git a/tests/server/tasks/test_result_aggregator.py b/tests/server/tasks/test_result_aggregator.py
@@ -56,7 +56,7 @@ def create_sample_status_update(
         task_id=task_id,
         context_id=context_id,
         status=TaskStatus(state=status_state),
-          # Typically false unless it's the very last update
+        # Typically false unless it's the very last update
     )
 
 
diff --git a/tests/server/tasks/test_task_manager.py b/tests/server/tasks/test_task_manager.py
@@ -118,7 +118,6 @@ async def test_save_task_event_status_update(
         task_id=MINIMAL_TASK_ID,
         context_id=MINIMAL_CONTEXT_ID,
         status=new_status,
-        
     )
     await task_manager.save_task_event(event)
     # Verify save was called and the task has updated status
@@ -168,7 +167,6 @@ async def test_save_task_event_metadata_update(
         context_id=MINIMAL_CONTEXT_ID,
         metadata=new_metadata,
         status=TaskStatus(state=TaskState.TASK_STATE_WORKING),
-        
     )
     await task_manager.save_task_event(event)
 
@@ -187,7 +185,6 @@ async def test_ensure_task_existing(
         task_id=MINIMAL_TASK_ID,
         context_id=MINIMAL_CONTEXT_ID,
         status=TaskStatus(state=TaskState.TASK_STATE_WORKING),
-        
     )
     retrieved_task = await task_manager.ensure_task(event)
     assert retrieved_task == expected_task
@@ -210,7 +207,6 @@ async def test_ensure_task_nonexistent(
         task_id='new-task',
         context_id='some-context',
         status=TaskStatus(state=TaskState.TASK_STATE_SUBMITTED),
-        
     )
     new_task = await task_manager_without_id.ensure_task(event)
     assert new_task.id == 'new-task'
@@ -313,7 +309,6 @@ async def test_save_task_event_no_task_existing(
         task_id='event-task-id',
         context_id='some-context',
         status=TaskStatus(state=TaskState.TASK_STATE_COMPLETED),
-        
     )
     await task_manager_without_id.save_task_event(event)
     # Check if a new task was created and saved
