Skip to content

Commit 57cb529

Browse files
Akshat8510ishymko
andauthored
fix(client): align send_message signature with BaseClient (#740)
# Description Aligned the `send_message` signature in `Client` with `BaseClient`. Note: I used `SendMessageConfiguration` (instead of `MessageSendConfiguration` mentioned in the issue) because `SendMessageConfiguration` is the correct attribute name found in `a2a_pb2`, as verified by `mypy`. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [X] Follow the [`CONTRIBUTING` Guide](https://github.com/a2aproject/a2a-python/blob/main/CONTRIBUTING.md). - [X] Make your Pull Request title in the <https://www.conventionalcommits.org/> specification. - Important Prefixes for [release-please](https://github.com/googleapis/release-please): - `fix:` which represents bug fixes, and correlates to a [SemVer](https://semver.org/) patch. - `feat:` represents a new feature, and correlates to a SemVer minor. - `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking change (indicated by the `!`) and will result in a SemVer major. - [X] Ensure the tests and linter pass (Run `bash scripts/format.sh` from the repository root to format) - [ ] Appropriate docs were updated (if necessary) Fixes #727 🦕 --------- Signed-off-by: Akshat Kumar <akshat230405@gmail.com> Co-authored-by: Ivan Shymko <ishymko@google.com>
1 parent 7998a26 commit 57cb529

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

src/a2a/client/client.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
ListTasksResponse,
2020
Message,
2121
PushNotificationConfig,
22+
SendMessageConfiguration,
2223
StreamResponse,
2324
SubscribeToTaskRequest,
2425
Task,
@@ -111,6 +112,7 @@ async def send_message(
111112
self,
112113
request: Message,
113114
*,
115+
configuration: SendMessageConfiguration | None = None,
114116
context: ClientCallContext | None = None,
115117
request_metadata: dict[str, Any] | None = None,
116118
extensions: list[str] | None = None,

0 commit comments

Comments
 (0)