fix: resolve linting errors (N818, D101, UP038, SIM101, BLE001)

Signed-off-by: Luca Muscariello <muscariello@ieee.org>

Author: muscariello

src/a2a/server/apps/jsonrpc/fastapi_app.py

@@ -51,15 +51,15 @@ def openapi(self) -> dict[str, Any]:
         # Try to use the a2a.json schema generated from the proto file
         # if available, instead of generating one from the python types.
         try:
-            from a2a import types
+            from a2a import types  # noqa: PLC0415
 
             schema_file = importlib.resources.files(types).joinpath('a2a.json')
             if schema_file.is_file():
                 self.openapi_schema = json.loads(
                     schema_file.read_text(encoding='utf-8')
                 )
                 return self.openapi_schema
-        except Exception:  # pylint: disable=broad-except
+        except Exception:  # noqa: BLE001
             logger.warning(
                 "Could not load 'a2a.json' from 'a2a.types'. Falling back to auto-generation."
             )

src/a2a/server/apps/jsonrpc/jsonrpc_app.py

@@ -242,7 +242,7 @@ def _generate_error_response(
         Returns:
             A `JSONResponse` object formatted as a JSON-RPC error response.
         """
-        if not isinstance(error, (A2AException, JSONRPCError)):
+        if not isinstance(error, A2AException | JSONRPCError):
             error = InternalError(message=str(error))
 
         response_data = build_error_response(request_id, error)

src/a2a/server/events/event_consumer.py

@@ -102,10 +102,7 @@ async def consume_all(self) -> AsyncGenerator[Event]:
                 )
 
                 is_final_event = isinstance(event, Message) or (
-                    (
-                        isinstance(event, Task)
-                        or isinstance(event, TaskStatusUpdateEvent)
-                    )
+                    isinstance(event, Task | TaskStatusUpdateEvent)
                     and event.status.state
                     in (
                         TaskState.TASK_STATE_COMPLETED,

src/a2a/server/jsonrpc_models.py

@@ -4,6 +4,8 @@
 
 
 class JSONRPCBaseModel(BaseModel):
+    """Base model for JSON-RPC objects."""
+
     model_config = {
         'extra': 'allow',
         'populate_by_name': True,
@@ -12,31 +14,43 @@ class JSONRPCBaseModel(BaseModel):
 
 
 class JSONRPCError(JSONRPCBaseModel):
+    """Base model for JSON-RPC error objects."""
+
     code: int
     message: str
     data: Any | None = None
 
 
 class JSONParseError(JSONRPCError):
+    """Error raised when invalid JSON was received by the server."""
+
     code: Literal[-32700] = -32700
     message: str = 'Parse error'
 
 
 class InvalidRequestError(JSONRPCError):
+    """Error raised when the JSON sent is not a valid Request object."""
+
     code: Literal[-32600] = -32600
     message: str = 'Invalid Request'
 
 
 class MethodNotFoundError(JSONRPCError):
+    """Error raised when the method does not exist / is not available."""
+
     code: Literal[-32601] = -32601
     message: str = 'Method not found'
 
 
 class InvalidParamsError(JSONRPCError):
+    """Error raised when invalid method parameter(s)."""
+
     code: Literal[-32602] = -32602
     message: str = 'Invalid params'
 
 
 class InternalError(JSONRPCError):
+    """Error raised when internal JSON-RPC error."""
+
     code: Literal[-32603] = -32603
     message: str = 'Internal error'

src/a2a/server/request_handlers/response_helpers.py

@@ -143,7 +143,7 @@ def prepare_response_object(
             result = MessageToDict(response, preserving_proto_field_name=False)
         return JSONRPC20Response(result=result, _id=request_id).data
 
-    if isinstance(response, (A2AException, JSONRPCError)):
+    if isinstance(response, A2AException | JSONRPCError):
         return build_error_response(request_id, response)
 
     # If response is not an expected success type and not an error,

src/a2a/utils/errors.py

@@ -5,7 +5,7 @@
 """
 
 
-class A2AException(Exception):
+class A2AError(Exception):
     """Base exception for A2A errors."""
 
     message: str = 'A2A Error'
@@ -16,54 +16,81 @@ def __init__(self, message: str | None = None):
         super().__init__(self.message)
 
 
-class TaskNotFoundError(A2AException):
+class TaskNotFoundError(A2AError):
+    """Exception raised when a task is not found."""
+
     message = 'Task not found'
 
 
-class TaskNotCancelableError(A2AException):
+class TaskNotCancelableError(A2AError):
+    """Exception raised when a task cannot be canceled."""
+
     message = 'Task cannot be canceled'
 
 
-class PushNotificationNotSupportedError(A2AException):
+class PushNotificationNotSupportedError(A2AError):
+    """Exception raised when push notifications are not supported."""
+
     message = 'Push Notification is not supported'
 
 
-class UnsupportedOperationError(A2AException):
+class UnsupportedOperationError(A2AError):
+    """Exception raised when an operation is not supported."""
+
     message = 'This operation is not supported'
 
 
-class ContentTypeNotSupportedError(A2AException):
+class ContentTypeNotSupportedError(A2AError):
+    """Exception raised when the content type is incompatible."""
+
     message = 'Incompatible content types'
 
 
-class InternalError(A2AException):
+class InternalError(A2AError):
+    """Exception raised for internal server errors."""
+
     message = 'Internal error'
 
 
-class InvalidAgentResponseError(A2AException):
+class InvalidAgentResponseError(A2AError):
+    """Exception raised when the agent response is invalid."""
+
     message = 'Invalid agent response'
 
 
-class AuthenticatedExtendedCardNotConfiguredError(A2AException):
+class AuthenticatedExtendedCardNotConfiguredError(A2AError):
+    """Exception raised when the authenticated extended card is not configured."""
+
     message = 'Authenticated Extended Card is not configured'
 
 
-class InvalidParamsError(A2AException):
+class InvalidParamsError(A2AError):
+    """Exception raised when parameters are invalid."""
+
     message = 'Invalid params'
 
 
-class InvalidRequestError(A2AException):
+class InvalidRequestError(A2AError):
+    """Exception raised when the request is invalid."""
+
     message = 'Invalid Request'
 
 
-class MethodNotFoundError(A2AException):
+class MethodNotFoundError(A2AError):
+    """Exception raised when a method is not found."""
+
     message = 'Method not found'
 
 
+# For backward compatibility
+A2AException = A2AError
+
+
 # For backward compatibility if needed, or just aliases for clean refactor
 # We remove the Pydantic models here.
 
 __all__ = [
+    'A2AError',
     'A2AException',
     'A2AServerError',
     'AuthenticatedExtendedCardNotConfiguredError',