refactor(client)!: rename "callback" -> "push_notification_config" (#749)

Currently client uses `callback` terminology for push notifications
which doesn't match the spec and data model names coming from the proto.
In addition having `get_task` and `get_task_callback` side by side may
give an impression that `get_task_callback` is some sort of an extension
point for `get_task` rather than a completely different method.

Re #702.

Author: ishymko

src/a2a/client/base_client.py

@@ -208,7 +208,7 @@ async def cancel_task(
             request, context=context, extensions=extensions
         )
 
-    async def set_task_callback(
+    async def create_task_push_notification_config(
         self,
         request: CreateTaskPushNotificationConfigRequest,
         *,
@@ -225,11 +225,11 @@ async def set_task_callback(
         Returns:
             The created or updated `TaskPushNotificationConfig` object.
         """
-        return await self._transport.set_task_callback(
+        return await self._transport.create_task_push_notification_config(
             request, context=context, extensions=extensions
         )
 
-    async def get_task_callback(
+    async def get_task_push_notification_config(
         self,
         request: GetTaskPushNotificationConfigRequest,
         *,
@@ -246,11 +246,11 @@ async def get_task_callback(
         Returns:
             A `TaskPushNotificationConfig` object containing the configuration.
         """
-        return await self._transport.get_task_callback(
+        return await self._transport.get_task_push_notification_config(
             request, context=context, extensions=extensions
         )
 
-    async def list_task_callback(
+    async def list_task_push_notification_configs(
         self,
         request: ListTaskPushNotificationConfigsRequest,
         *,
@@ -267,11 +267,11 @@ async def list_task_callback(
         Returns:
             A `ListTaskPushNotificationConfigsResponse` object.
         """
-        return await self._transport.list_task_callback(
+        return await self._transport.list_task_push_notification_configs(
             request, context=context, extensions=extensions
         )
 
-    async def delete_task_callback(
+    async def delete_task_push_notification_config(
         self,
         request: DeleteTaskPushNotificationConfigRequest,
         *,
@@ -285,7 +285,7 @@ async def delete_task_callback(
             context: The client call context.
             extensions: List of extensions to be activated.
         """
-        await self._transport.delete_task_callback(
+        await self._transport.delete_task_push_notification_config(
             request, context=context, extensions=extensions
         )
 

src/a2a/client/client.py

@@ -71,7 +71,7 @@ class ClientConfig:
     push_notification_configs: list[PushNotificationConfig] = dataclasses.field(
         default_factory=list
     )
-    """Push notification callbacks to use for every request."""
+    """Push notification configurations to use for every request."""
 
     extensions: list[str] = dataclasses.field(default_factory=list)
     """A list of extension URIs the client supports."""
@@ -161,7 +161,7 @@ async def cancel_task(
         """Requests the agent to cancel a specific task."""
 
     @abstractmethod
-    async def set_task_callback(
+    async def create_task_push_notification_config(
         self,
         request: CreateTaskPushNotificationConfigRequest,
         *,
@@ -171,7 +171,7 @@ async def set_task_callback(
         """Sets or updates the push notification configuration for a specific task."""
 
     @abstractmethod
-    async def get_task_callback(
+    async def get_task_push_notification_config(
         self,
         request: GetTaskPushNotificationConfigRequest,
         *,
@@ -181,7 +181,7 @@ async def get_task_callback(
         """Retrieves the push notification configuration for a specific task."""
 
     @abstractmethod
-    async def list_task_callback(
+    async def list_task_push_notification_configs(
         self,
         request: ListTaskPushNotificationConfigsRequest,
         *,
@@ -191,7 +191,7 @@ async def list_task_callback(
         """Lists push notification configurations for a specific task."""
 
     @abstractmethod
-    async def delete_task_callback(
+    async def delete_task_push_notification_config(
         self,
         request: DeleteTaskPushNotificationConfigRequest,
         *,

src/a2a/client/transports/base.py

@@ -94,7 +94,7 @@ async def cancel_task(
         """Requests the agent to cancel a specific task."""
 
     @abstractmethod
-    async def set_task_callback(
+    async def create_task_push_notification_config(
         self,
         request: CreateTaskPushNotificationConfigRequest,
         *,
@@ -104,7 +104,7 @@ async def set_task_callback(
         """Sets or updates the push notification configuration for a specific task."""
 
     @abstractmethod
-    async def get_task_callback(
+    async def get_task_push_notification_config(
         self,
         request: GetTaskPushNotificationConfigRequest,
         *,
@@ -114,7 +114,7 @@ async def get_task_callback(
         """Retrieves the push notification configuration for a specific task."""
 
     @abstractmethod
-    async def list_task_callback(
+    async def list_task_push_notification_configs(
         self,
         request: ListTaskPushNotificationConfigsRequest,
         *,
@@ -124,7 +124,7 @@ async def list_task_callback(
         """Lists push notification configurations for a specific task."""
 
     @abstractmethod
-    async def delete_task_callback(
+    async def delete_task_push_notification_config(
         self,
         request: DeleteTaskPushNotificationConfigRequest,
         *,

src/a2a/client/transports/grpc.py

@@ -175,7 +175,7 @@ async def cancel_task(
             metadata=self._get_grpc_metadata(extensions),
         )
 
-    async def set_task_callback(
+    async def create_task_push_notification_config(
         self,
         request: CreateTaskPushNotificationConfigRequest,
         *,
@@ -188,7 +188,7 @@ async def set_task_callback(
             metadata=self._get_grpc_metadata(extensions),
         )
 
-    async def get_task_callback(
+    async def get_task_push_notification_config(
         self,
         request: GetTaskPushNotificationConfigRequest,
         *,
@@ -201,7 +201,7 @@ async def get_task_callback(
             metadata=self._get_grpc_metadata(extensions),
         )
 
-    async def list_task_callback(
+    async def list_task_push_notification_configs(
         self,
         request: ListTaskPushNotificationConfigsRequest,
         *,
@@ -214,7 +214,7 @@ async def list_task_callback(
             metadata=self._get_grpc_metadata(extensions),
         )
 
-    async def delete_task_callback(
+    async def delete_task_push_notification_config(
         self,
         request: DeleteTaskPushNotificationConfigRequest,
         *,

src/a2a/client/transports/jsonrpc.py

@@ -303,7 +303,7 @@ async def cancel_task(
         response: Task = json_format.ParseDict(json_rpc_response.result, Task())
         return response
 
-    async def set_task_callback(
+    async def create_task_push_notification_config(
         self,
         request: CreateTaskPushNotificationConfigRequest,
         *,
@@ -335,7 +335,7 @@ async def set_task_callback(
         )
         return response
 
-    async def get_task_callback(
+    async def get_task_push_notification_config(
         self,
         request: GetTaskPushNotificationConfigRequest,
         *,
@@ -367,7 +367,7 @@ async def get_task_callback(
         )
         return response
 
-    async def list_task_callback(
+    async def list_task_push_notification_configs(
         self,
         request: ListTaskPushNotificationConfigsRequest,
         *,
@@ -402,7 +402,7 @@ async def list_task_callback(
         )
         return response
 
-    async def delete_task_callback(
+    async def delete_task_push_notification_config(
         self,
         request: DeleteTaskPushNotificationConfigRequest,
         *,

src/a2a/client/transports/rest.py

@@ -298,7 +298,7 @@ async def cancel_task(
         response: Task = ParseDict(response_data, Task())
         return response
 
-    async def set_task_callback(
+    async def create_task_push_notification_config(
         self,
         request: CreateTaskPushNotificationConfigRequest,
         *,
@@ -324,7 +324,7 @@ async def set_task_callback(
         )
         return response
 
-    async def get_task_callback(
+    async def get_task_push_notification_config(
         self,
         request: GetTaskPushNotificationConfigRequest,
         *,
@@ -356,7 +356,7 @@ async def get_task_callback(
         )
         return response
 
-    async def list_task_callback(
+    async def list_task_push_notification_configs(
         self,
         request: ListTaskPushNotificationConfigsRequest,
         *,
@@ -386,7 +386,7 @@ async def list_task_callback(
         )
         return response
 
-    async def delete_task_callback(
+    async def delete_task_push_notification_config(
         self,
         request: DeleteTaskPushNotificationConfigRequest,
         *,

tests/client/transports/test_grpc_client.py

@@ -418,7 +418,7 @@ async def test_cancel_task(
 
 
 @pytest.mark.asyncio
-async def test_set_task_callback_with_valid_task(
+async def test_create_task_push_notification_config_with_valid_task(
     grpc_transport: GrpcTransport,
     mock_grpc_stub: AsyncMock,
     sample_task_push_notification_config: TaskPushNotificationConfig,
@@ -433,7 +433,9 @@ async def test_set_task_callback_with_valid_task(
         task_id='task-1',
         config=sample_task_push_notification_config.push_notification_config,
     )
-    response = await grpc_transport.set_task_callback(request)
+    response = await grpc_transport.create_task_push_notification_config(
+        request
+    )
 
     mock_grpc_stub.CreateTaskPushNotificationConfig.assert_awaited_once_with(
         request,
@@ -448,7 +450,7 @@ async def test_set_task_callback_with_valid_task(
 
 
 @pytest.mark.asyncio
-async def test_set_task_callback_with_invalid_task(
+async def test_create_task_push_notification_config_with_invalid_task(
     grpc_transport: GrpcTransport,
     mock_grpc_stub: AsyncMock,
     sample_push_notification_config: PushNotificationConfig,
@@ -469,12 +471,14 @@ async def test_set_task_callback_with_invalid_task(
 
     # Note: The transport doesn't validate the response name format
     # It just returns the response from the stub
-    response = await grpc_transport.set_task_callback(request)
+    response = await grpc_transport.create_task_push_notification_config(
+        request
+    )
     assert response.task_id == 'invalid-path-to-task-1'
 
 
 @pytest.mark.asyncio
-async def test_get_task_callback_with_valid_task(
+async def test_get_task_push_notification_config_with_valid_task(
     grpc_transport: GrpcTransport,
     mock_grpc_stub: AsyncMock,
     sample_task_push_notification_config: TaskPushNotificationConfig,
@@ -485,7 +489,7 @@ async def test_get_task_callback_with_valid_task(
     )
     config_id = sample_task_push_notification_config.push_notification_config.id
 
-    response = await grpc_transport.get_task_callback(
+    response = await grpc_transport.get_task_push_notification_config(
         GetTaskPushNotificationConfigRequest(
             task_id='task-1',
             id=config_id,
@@ -508,7 +512,7 @@ async def test_get_task_callback_with_valid_task(
 
 
 @pytest.mark.asyncio
-async def test_get_task_callback_with_invalid_task(
+async def test_get_task_push_notification_config_with_invalid_task(
     grpc_transport: GrpcTransport,
     mock_grpc_stub: AsyncMock,
     sample_push_notification_config: PushNotificationConfig,
@@ -521,7 +525,7 @@ async def test_get_task_callback_with_invalid_task(
         )
     )
 
-    response = await grpc_transport.get_task_callback(
+    response = await grpc_transport.get_task_push_notification_config(
         GetTaskPushNotificationConfigRequest(
             task_id='task-1',
             id='config-1',
@@ -532,7 +536,7 @@ async def test_get_task_callback_with_invalid_task(
 
 
 @pytest.mark.asyncio
-async def test_list_task_callback(
+async def test_list_task_push_notification_configs(
     grpc_transport: GrpcTransport,
     mock_grpc_stub: AsyncMock,
     sample_task_push_notification_config: TaskPushNotificationConfig,
@@ -544,7 +548,7 @@ async def test_list_task_callback(
         )
     )
 
-    response = await grpc_transport.list_task_callback(
+    response = await grpc_transport.list_task_push_notification_configs(
         ListTaskPushNotificationConfigsRequest(task_id='task-1')
     )
 
@@ -562,15 +566,15 @@ async def test_list_task_callback(
 
 
 @pytest.mark.asyncio
-async def test_delete_task_callback(
+async def test_delete_task_push_notification_config(
     grpc_transport: GrpcTransport,
     mock_grpc_stub: AsyncMock,
     sample_task_push_notification_config: TaskPushNotificationConfig,
 ) -> None:
     """Test deleting task push notification config."""
     mock_grpc_stub.DeleteTaskPushNotificationConfig.return_value = None
 
-    await grpc_transport.delete_task_callback(
+    await grpc_transport.delete_task_push_notification_config(
         DeleteTaskPushNotificationConfigRequest(
             task_id='task-1',
             id='config-1',