Skip to content

Commit 4dfef9d

Browse files
committed
Remove Guava (for now)
1 parent 49000d4 commit 4dfef9d

7 files changed

Lines changed: 21 additions & 33 deletions

File tree

pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,6 @@
7070
<version>0.9.3</version>
7171
</dependency>
7272

73-
<dependency>
74-
<groupId>com.google.guava</groupId>
75-
<artifactId>guava</artifactId>
76-
<version>27.0-jre</version>
77-
</dependency>
78-
7973
<dependency>
8074
<groupId>com.google.code.gson</groupId>
8175
<artifactId>gson</artifactId>

src/main/java/com/comphenix/rema1000/Application.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import com.comphenix.rema1000.model.DataRoot;
66
import com.comphenix.rema1000.model.ReceiptEntry;
77
import com.comphenix.rema1000.model.Transaction;
8-
import com.google.common.io.MoreFiles;
98
import com.google.gson.Gson;
109
import com.google.gson.stream.JsonReader;
1110

@@ -128,8 +127,9 @@ private static OutputStream getOutput(ArgumentParser parser) throws IOException
128127
Path outputFile = parser.getDestination();
129128

130129
if (extension != null && outputFile != null) {
131-
@SuppressWarnings("UnstableApiUsage")
132-
String fileExtension = MoreFiles.getFileExtension(outputFile);
130+
String fileName = outputFile.getFileName().toString();
131+
int dotIndex = fileName.lastIndexOf('.');
132+
String fileExtension = dotIndex != -1 ? fileName.substring(dotIndex + 1) : "";
133133

134134
// Error
135135
if (!extension.equalsIgnoreCase(fileExtension)) {

src/main/java/com/comphenix/rema1000/io/AbstractTableWriter.java

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,24 @@
11
package com.comphenix.rema1000.io;
22

3-
import com.google.common.collect.BiMap;
4-
import com.google.common.collect.HashBiMap;
5-
63
import java.io.IOException;
7-
import java.util.Collections;
8-
import java.util.Objects;
9-
import java.util.Set;
4+
import java.util.*;
105

116
public abstract class AbstractTableWriter implements TableWriter {
127
// Index of the current column (initially -1)
138
private int columnIndex = -1;
14-
protected BiMap<String, Integer> headerLookup = HashBiMap.create();
9+
protected Map<String, Integer> headerIndexLookup = new HashMap<>();
10+
protected Map<Integer, String> headerNameLookup = new HashMap<>();
1511

1612
protected boolean closed;
1713

1814
@Override
1915
public int getHeaderIndex(String header) {
20-
return headerLookup.getOrDefault(header, -1);
16+
return headerIndexLookup.getOrDefault(header, -1);
2117
}
2218

2319
@Override
2420
public String getHeaderName(int index) {
25-
return headerLookup.inverse().get(index);
21+
return headerNameLookup.get(index);
2622
}
2723

2824
@Override
@@ -32,19 +28,20 @@ public int getHeaderCount() {
3228

3329
@Override
3430
public Set<String> headers() {
35-
return Collections.unmodifiableSet(headerLookup.keySet());
31+
return Collections.unmodifiableSet(headerIndexLookup.keySet());
3632
}
3733

3834
@Override
3935
public int createHeader(String headerName) throws IOException {
4036
checkClosed();
41-
Integer existing = headerLookup.get(headerName);
37+
Integer existing = headerIndexLookup.get(headerName);
4238

4339
if (existing == null) {
4440
int column = ++columnIndex;
4541

4642
onHeaderCreated(headerName, column);
47-
headerLookup.put(headerName, column);
43+
headerIndexLookup.put(headerName, column);
44+
headerNameLookup.put(column, headerName);
4845
return column;
4946
}
5047
return existing;

src/main/java/com/comphenix/rema1000/io/DataTableConverter.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
package com.comphenix.rema1000.io;
22

33
import com.comphenix.rema1000.model.*;
4-
import com.google.common.collect.ImmutableList;
54

65
import java.io.IOException;
76
import java.time.Instant;
87
import java.util.Comparator;
98
import java.util.List;
9+
import java.util.stream.Collectors;
1010

1111
/**
1212
* Convert data to individual tables.
@@ -80,8 +80,9 @@ public void writeTableTopList(TableWriter writer, TopListMetadata metadata) thro
8080
int volume = createHeader(writer, "Volume");
8181

8282
// Sort entries by rank
83-
ImmutableList<ScorecardEntry> entries = ImmutableList.sortedCopyOf(
84-
Comparator.comparing(ScorecardEntry::getRank), metadata.getScorecard());
83+
List<ScorecardEntry> entries = metadata.getScorecard().stream().sorted(
84+
Comparator.comparing(ScorecardEntry::getRank)).
85+
collect(Collectors.toList());
8586

8687
for (ScorecardEntry entry : entries) {
8788
writer.incrementRow();

src/main/java/com/comphenix/rema1000/io/DataWriter.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
import java.io.IOException;
44
import java.io.OutputStream;
5-
import java.nio.file.Files;
6-
import java.nio.file.Path;
75

86
public abstract class DataWriter<T> {
97
/**

src/main/java/com/comphenix/rema1000/io/sql/SqlTableWriter.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
package com.comphenix.rema1000.io.sql;
22

33
import com.comphenix.rema1000.io.AbstractTableWriter;
4-
import com.google.common.base.Strings;
5-
import com.google.common.collect.Maps;
64
import com.google.gson.internal.Primitives;
75

86
import java.io.IOException;
@@ -73,7 +71,7 @@ public int hashCode() {
7371
private final String lineBreak = System.lineSeparator();
7472

7573
// Current columns
76-
private Map<String, TableColumn> tableColumns = Maps.newHashMap();
74+
private Map<String, TableColumn> tableColumns = new HashMap<>();
7775

7876
// Current values to be written to the output
7977
private List<Object> values = new ArrayList<>();
@@ -118,7 +116,7 @@ public TableColumn getTableColumn(int headerIndex) {
118116
public TableColumn getTableColumn(String headerName) {
119117
TableColumn result = tableColumns.get(headerName);
120118

121-
if (result == null && headerLookup.containsKey(headerName)) {
119+
if (result == null && headerIndexLookup.containsKey(headerName)) {
122120
// Default column
123121
result = new TableColumn(headerName);
124122
}
@@ -208,7 +206,7 @@ protected void writeHeaders() throws IOException {
208206
builder.append(" ");
209207
writeColumnType(builder, columnType);
210208
}
211-
if (!Strings.isNullOrEmpty(column.getForeignTable())) {
209+
if (column.getForeignTable() != null && !column.getForeignTable().isEmpty()) {
212210
builder.append(" REFERENCES ");
213211
writeIdentifier(builder, column.getForeignTable());
214212
builder.append("(");

src/main/java/com/comphenix/rema1000/io/sql/SqlWriter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@
66
import com.comphenix.rema1000.model.DataRoot;
77
import com.comphenix.rema1000.model.Transaction;
88
import com.comphenix.rema1000.model.TransactionsInfo;
9-
import com.google.common.base.Charsets;
109

1110
import java.io.BufferedWriter;
1211
import java.io.IOException;
1312
import java.io.OutputStream;
1413
import java.io.OutputStreamWriter;
14+
import java.nio.charset.StandardCharsets;
1515
import java.util.List;
1616

1717
public class SqlWriter extends DataWriter<DataRoot> {
@@ -25,7 +25,7 @@ protected String getHeaderName(TableWriter writer, String headerName) {
2525

2626
@Override
2727
public void write(OutputStream output, DataRoot data) throws IOException {
28-
try (BufferedWriter writer = new BufferedWriter(new OutputStreamWriter(output, Charsets.UTF_8))) {
28+
try (BufferedWriter writer = new BufferedWriter(new OutputStreamWriter(output, StandardCharsets.UTF_8))) {
2929

3030
try (SqlTableWriter tableWriter = new SqlTableWriter("TopList", writer)) {
3131
tableWriter.putTableColumn("rank", new SqlTableWriter.TableColumn(

0 commit comments

Comments
 (0)