Permissions with no extra arguments

Author: brunovcosta

abstra_json_sql/authorization.py

@@ -126,24 +126,14 @@ def __init__(self, default: bool = False):
         self.rules = []
 
     def grant(
-        self, command: RuleCommand, table_name: str, condition: Optional[str]
+        self, command: RuleCommand, table_name: str, condition: Optional[str] = None
     ) -> "ITablesSnapshot":
-        if condition is None:
-
-            def condition(_):
-                return self.default
-
         self.rules.append(Rule("GRANT", command, table_name, condition))
         return self
 
     def revoke(
-        self, command: RuleCommand, table_name: str, condition: Optional[str]
+        self, command: RuleCommand, table_name: str, condition: Optional[str] = None
     ) -> "ITablesSnapshot":
-        if condition is None:
-
-            def condition(_):
-                return not self.default
-
         self.rules.append(Rule("REVOKE", command, table_name, condition))
         return self
 

abstra_json_sql/authorization_test.py

@@ -4,6 +4,13 @@
 
 
 class TestPermissions(TestCase):
+    def test_grant_no_conditions(self):
+        p = Permissions(default=False)
+        p.grant("SELECT", "users")
+
+        self.assertTrue(p.allowed("select * from users"))
+        self.assertTrue(p.allowed("select * from users where age > 18"))
+
     def test_select(self):
         p = Permissions(default=False)
         p.grant("SELECT", "users", "age > 18")