Summary
The sell slippage check should revert only when proceeds fall strictly below min_proceeds. When proceeds equal min_proceeds exactly the transaction must succeed. This boundary condition needs an explicit regression test mirroring the buy-side slippage boundary test.
Scope
- Get the sell quote for a given supply and amount
- Call sell with
min_proceeds set to exactly the quoted proceeds
- Assert the sell succeeds
- Call sell with
min_proceeds set to one stroop above the quoted proceeds
- Assert the sell reverts with
SlippageExceeded
Acceptance Criteria
ETA: 12 hours
Coordinate on Telegram
Summary
The sell slippage check should revert only when proceeds fall strictly below
min_proceeds. When proceeds equalmin_proceedsexactly the transaction must succeed. This boundary condition needs an explicit regression test mirroring the buy-side slippage boundary test.Scope
min_proceedsset to exactly the quoted proceedsmin_proceedsset to one stroop above the quoted proceedsSlippageExceededAcceptance Criteria
min_proceedsequals actual proceeds exactlymin_proceedsis one stroop above actual proceedsETA: 12 hours
Coordinate on Telegram