Skip to content

Commit 4a4877c

Browse files
author
Srdjan Marjanovic
committed
Fixes per merge request comments.
1 parent e9bd9fe commit 4a4877c

7 files changed

Lines changed: 4 additions & 43 deletions

File tree

src/ActiveCollab/EmailReplyExtractor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public static function extractReplyEml($path)
3333

3434
$extractor = self::getExtractorEml(self::detectMailer(self::getHeadersRelevantForMailerDetectionEml($parser)), $parser);
3535

36-
return (string) trim($extractor->body);
36+
return trim($extractor->body);
3737
}
3838

3939
/**

src/ActiveCollab/EmailReplyExtractor/Extractor/AndroidMailExtractor.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
<?php
22
namespace ActiveCollab\EmailReplyExtractor\Extractor;
33

4-
4+
/**
5+
* @package ActiveCollab\EmailReplyExtractor\Extractor
6+
*/
57
final class AndroidMailExtractor extends Extractor
68
{
79
/**
@@ -19,10 +21,6 @@ protected function processLines()
1921
$this->body = array_splice($this->body, 0, $cut_line);
2022
}
2123

22-
if (preg_match('/^Am(.*?)schrieb(.*?)/is', $unwanted_text)) {
23-
$this->body = array_splice($this->body, 0, $cut_line);
24-
}
25-
2624
// default signature
2725
$match_string = '^sent from(.*?)';
2826
// strip default signature

src/ActiveCollab/EmailReplyExtractor/Extractor/AppleMailExtractor.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ protected function processLines()
3737
/**
3838
* Return original message splitters
3939
*
40-
* @todo
4140
* @return array
4241
*/
4342
protected function getOriginalMessageSplitters()

src/ActiveCollab/EmailReplyExtractor/Extractor/Extractor.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ public function joinLines()
7373
/**
7474
* Return original message splitters
7575
*
76-
* @todo
7776
* @return array
7877
*/
7978
protected function getOriginalMessageSplitters()

src/ActiveCollab/EmailReplyExtractor/Extractor/GenericExtractor.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,6 @@
66
*/
77
final class GenericExtractor extends Extractor
88
{
9-
public static function toPlainText($html)
10-
{
11-
$html = str_replace('div', 'p', $html);
12-
13-
return parent::toPlainText($html);
14-
}
15-
169
/**
1710
* Return splitters
1811
*

src/ActiveCollab/EmailReplyExtractor/Extractor/OutlookExpressExtractor.php

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,10 @@
66
*/
77
final class OutlookExpressExtractor extends Extractor
88
{
9-
/**
10-
* @param string $html
11-
*
12-
* @return string
13-
*/
14-
static function toPlainText($html)
15-
{
16-
$html = str_replace('div', 'p', $html);
17-
18-
return parent::toPlainText($html);
19-
}
209

2110
/**
2211
* Return original message splitters
2312
*
24-
* @todo
2513
* @return array
2614
*/
2715
protected function getOriginalMessageSplitters()

src/ActiveCollab/EmailReplyExtractor/Extractor/OutlookExtractor.php

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,6 @@
66
*/
77
final class OutlookExtractor extends Extractor
88
{
9-
/**
10-
* Overrides Extractor::toPlaineText()
11-
*
12-
* @param string $html
13-
*
14-
* @return string
15-
*/
16-
static function toPlainText($html)
17-
{
18-
$html = str_replace('div', 'p', $html);
19-
20-
return parent::toPlainText($html);
21-
}
22-
23-
249
public function processLines()
2510
{
2611
parent::processLines();
@@ -52,7 +37,6 @@ public function stripSignature()
5237
/**
5338
* Return original message splitters
5439
*
55-
* @todo
5640
* @return array
5741
*/
5842
protected function getOriginalMessageSplitters()

0 commit comments

Comments
 (0)