From e1aadfa3b4bd958f8ed3a78db3c9b7b59fd814c8 Mon Sep 17 00:00:00 2001 From: johnrb2 Date: Tue, 7 Apr 2026 12:42:07 -0600 Subject: [PATCH 1/2] Upgrade to Node 24 with shared test workflow Migrate test.yml to use shared reusable workflow from activeprospect/github-action-workflows. Add .nvmrc and engines field. --- .github/workflows/test.yml | 23 +++++------------------ .nvmrc | 1 + package.json | 5 ++++- 3 files changed, 10 insertions(+), 19 deletions(-) create mode 100644 .nvmrc diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3051dff..4ec660e 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -2,22 +2,9 @@ name: Node.js CI on: push jobs: test: - runs-on: ubuntu-latest - strategy: - matrix: - node-version: [16.x, 18.x, latest] - env: + uses: activeprospect/github-action-workflows/.github/workflows/test.yml@master + with: + codecov: true + secrets: NPM_TOKEN: ${{ secrets.NPM_TOKEN }} - steps: - - uses: actions/checkout@v3 - - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 - with: - node-version: ${{ matrix.node-version }} - - run: npm install - - name: Run tests - run: npx nyc@latest --reporter=lcov npm test - - uses: codecov/codecov-action@v1 - with: - token: ${{ secrets.CODECOV_TOKEN }} + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} diff --git a/.nvmrc b/.nvmrc new file mode 100644 index 0000000..a45fd52 --- /dev/null +++ b/.nvmrc @@ -0,0 +1 @@ +24 diff --git a/package.json b/package.json index 802e46e..435909b 100644 --- a/package.json +++ b/package.json @@ -30,5 +30,8 @@ "bugs": { "url": "https://github.com/hughsk/flat/issues" }, - "homepage": "https://github.com/hughsk/flat" + "homepage": "https://github.com/hughsk/flat", + "engines": { + "node": ">=20" + } } From 351c357fd698be59030437e178a0c1742a091897 Mon Sep 17 00:00:00 2001 From: johnrb2 Date: Wed, 8 Apr 2026 10:23:25 -0600 Subject: [PATCH 2/2] trigger CI after shared workflow fix Made-with: Cursor --- .github/workflows/test.yml | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 4ec660e..031f3a9 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -2,9 +2,22 @@ name: Node.js CI on: push jobs: test: - uses: activeprospect/github-action-workflows/.github/workflows/test.yml@master - with: - codecov: true - secrets: + runs-on: ubuntu-latest + strategy: + matrix: + node-version: [20.x, 24.x] + env: NPM_TOKEN: ${{ secrets.NPM_TOKEN }} - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} + steps: + - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 + + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 + with: + node-version: ${{ matrix.node-version }} + - run: npm install + - name: Run tests + run: npx nyc@17.1.0 --reporter=lcov npm test + - uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3 + with: + token: ${{ secrets.CODECOV_TOKEN }}