Skip to content

Commit 5d7dd38

Browse files
committed
Corrected default_val parsing
1 parent 93a05af commit 5d7dd38

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

remove-json-keys/src/remove_json_keys/lib/settings.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,9 @@ def load(cli, caller_file):
7474
# Init all cli.config vals
7575
for name, ctrl in vars(controls).items():
7676
val = getattr(cli.config, name, '')
77-
if getattr(ctrl, 'parser', None) == 'csv':
77+
if getattr(ctrl, 'parser', '') == 'csv':
7878
val = data.csv.parse(val)
79-
if val is None and hasattr(ctrl, 'default_val'):
79+
if not val and hasattr(ctrl, 'default_val'):
8080
val = ctrl.default_val
8181
setattr(cli.config, name, val)
8282
log.debug('All cli.config vals set!\n{}', cli)

translate-messages/src/translate_messages/lib/settings.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,9 @@ def load(cli, caller_file):
8484
# Init all cli.config vals
8585
for name, ctrl in vars(controls).items():
8686
val = getattr(cli.config, name, '')
87-
if getattr(ctrl, 'parser', None) == 'csv':
87+
if getattr(ctrl, 'parser', '') == 'csv':
8888
val = data.csv.parse(val)
89-
if val is None and hasattr(ctrl, 'default_val'):
89+
if not val and hasattr(ctrl, 'default_val'):
9090
val = ctrl.default_val
9191
setattr(cli.config, name, val)
9292
log.debug('All cli.config vals set!\n{}', cli)

0 commit comments

Comments
 (0)