Skip to content

Commit 806eb08

Browse files
committed
Changed url.open() to raise exceptions instead of exiting
1 parent 9203c2a commit 806eb08

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

  • remove-json-keys/src/remove_json_keys/lib
  • translate-messages/src/translate_messages/lib

remove-json-keys/src/remove_json_keys/lib/url.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import sys, webbrowser
1+
import webbrowser
22
from urllib.error import URLError
33
from urllib.parse import urlparse
44
from urllib.request import urlopen
@@ -16,8 +16,7 @@ def open(url):
1616
try:
1717
webbrowser.open(url)
1818
except Exception as err:
19-
print(f'Failed to open browser: {err}', file=sys.stderr)
20-
sys.exit(1)
19+
raise RuntimeError(f'Failed to open {url} in browser browser: {err}')
2120

2221
def validate(url, allowed_schemes=('http', 'https'), allowed_domains=[]):
2322
parsed_url = urlparse(url)

translate-messages/src/translate_messages/lib/url.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import sys, webbrowser
1+
import webbrowser
22
from urllib.error import URLError
33
from urllib.parse import urlparse
44
from urllib.request import urlopen
@@ -16,8 +16,7 @@ def open(url):
1616
try:
1717
webbrowser.open(url)
1818
except Exception as err:
19-
print(f'Failed to open browser: {err}', file=sys.stderr)
20-
sys.exit(1)
19+
raise RuntimeError(f'Failed to open {url} in browser browser: {err}')
2120

2221
def validate(url, allowed_schemes=('http', 'https'), allowed_domains=[]):
2322
parsed_url = urlparse(url)

0 commit comments

Comments
 (0)