Skip to content

Commit b527def

Browse files
committed
Deleted unneeded None check for config_val in final parse of settings.load() (fixes #21)
1 parent d9fe072 commit b527def

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

remove-json-keys/src/remove_json_keys/lib/settings.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,6 @@ def load(cli):
128128
if not hasattr(cli.config, ctrl_key):
129129
setattr(cli.config, ctrl_key, ctrl.default_val if hasattr(ctrl, 'default_val') else None)
130130
config_val = getattr(cli.config, ctrl_key)
131-
if getattr(ctrl, 'parser', '') == 'csv' and config_val is not None:
131+
if getattr(ctrl, 'parser', '') == 'csv':
132132
setattr(cli.config, ctrl_key, data.csv.parse(config_val))
133133
log.debug('All cli.config vals set!', cli)

translate-messages/src/translate_messages/lib/settings.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,6 @@ def load(cli):
138138
if not hasattr(cli.config, ctrl_key):
139139
setattr(cli.config, ctrl_key, ctrl.default_val if hasattr(ctrl, 'default_val') else None)
140140
config_val = getattr(cli.config, ctrl_key)
141-
if getattr(ctrl, 'parser', '') == 'csv' and config_val is not None:
141+
if getattr(ctrl, 'parser', '') == 'csv':
142142
setattr(cli.config, ctrl_key, data.csv.parse(config_val))
143143
log.debug('All cli.config vals set!', cli)

0 commit comments

Comments
 (0)