getter used on models and 204 is now response on no preview not 404

canstudios-louisem · canstudios-louisem · commit 7e63aadf83cd · 2017-08-18T14:49:16.000+01:00
diff --git a/frontend/src/modules/editor/selectTheme/views/editorThemeItemView.js b/frontend/src/modules/editor/selectTheme/views/editorThemeItemView.js
@@ -24,7 +24,7 @@ define(function(require){
     },
 
     postRender: function() {
-      var previewUrl = '/api/theme/preview/' + this.model.attributes.name + '/' + this.model.attributes.version;
+      var previewUrl = '/api/theme/preview/' + this.model.get('name') + '/' + this.model.get('name')
       var $previewLoc = this.$('.theme-preview');
 
       $.ajax(previewUrl, {
diff --git a/plugins/content/theme/index.js b/plugins/content/theme/index.js
@@ -148,7 +148,7 @@ function initialize () {
         }
       ],function(err, img) {
         if(err){
-          res.sendStatus(404);
+          res.sendStatus(204);
           return res;
         }
         res.writeHead(200, {'Content-Type': 'image/jpg' });

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ function initialize () {`
`148`	`148`	`}`
`149`	`149`	`],function(err, img) {`
`150`	`150`	`if(err){`
`151`		`- res.sendStatus(404);`
	`151`	`+ res.sendStatus(204);`
`152`	`152`	`return res;`
`153`	`153`	`}`
`154`	`154`	`res.writeHead(200, {'Content-Type': 'image/jpg' });`