Skip to content

Commit a3ef21a

Browse files
Merge pull request #2532 from adaptlearning/issue/1892
Fix paste zones
2 parents 739578c + 5ce1875 commit a3ef21a

2 files changed

Lines changed: 3 additions & 31 deletions

File tree

frontend/src/modules/editor/contentObject/views/editorPageArticleView.js

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ define(function(require){
4848
var events = {};
4949
events['editorView:moveBlock:' + id] = this.render;
5050
events['editorView:deleteArticle:' + id] = this.deletePageArticle;
51-
events['editorView:pasted:' + id] = this.onPaste;
51+
events['editorView:pasted:' + id] = this.render;
5252
this.listenTo(Origin, events);
5353
}
5454

@@ -282,20 +282,6 @@ define(function(require){
282282
duration = 0;
283283
}
284284
this.$('.article-content').velocity(shouldCollapse ? 'slideUp' : 'slideDown', duration);
285-
},
286-
287-
onPaste: function(data) {
288-
(new BlockModel({ _id: data._id })).fetch({
289-
success: _.bind(function(model) {
290-
this.addBlockView(model);
291-
}, this),
292-
error: function(data) {
293-
Origin.Notify.alert({
294-
type: 'error',
295-
text: 'app.errorfetchingdata'
296-
});
297-
}
298-
});
299285
}
300286

301287
}, {

frontend/src/modules/editor/contentObject/views/editorPageView.js

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ define(function(require){
2727
'pageView:itemAnimated': this.evaluateChildStatus
2828
};
2929
originEvents['editorView:moveArticle:' + id] = this.render;
30-
originEvents['editorView:pasted:' + id] = this.onPaste;
30+
originEvents['editorView:pasted:' + id] = this.render;
3131
this.listenTo(Origin, originEvents);
3232

3333
Origin.options.addItems([
@@ -109,7 +109,7 @@ define(function(require){
109109
$.scrollTo(newArticleView.$el, 200);
110110
}
111111
// Increment the 'sortOrder' property
112-
articleModel.set('_pasteZoneSortOrder', sortOrder++);
112+
articleModel.set('_pasteZoneSortOrder', sortOrder + 1);
113113
// Post-article paste zone - sort order of placeholder will be one greater
114114
this.$('.page-articles').append(new EditorPasteZoneView({ model: articleModel }).$el);
115115
return newArticleView;
@@ -159,20 +159,6 @@ define(function(require){
159159
Origin.trigger('contextMenu:open', fakeView, event);
160160
},
161161

162-
onPaste: function(data) {
163-
(new ArticleModel({ _id: data._id })).fetch({
164-
success: _.bind(function(model) {
165-
this.addArticleView(model);
166-
}, this),
167-
error: function(data) {
168-
Origin.Notify.alert({
169-
type: 'error',
170-
text: 'app.errorfetchingdata'
171-
});
172-
}
173-
});
174-
},
175-
176162
onCutArticle: function(view) {
177163
this.once('pageView:postRender', view.showPasteZones);
178164
this.render();

0 commit comments

Comments
 (0)