Merge pull request #2469 from adaptlearning/issue/2467

Remove built schema cache, fixes #2467

Author: tomgreenfield

frontend/src/modules/scaffold/index.js

@@ -17,7 +17,6 @@ define([
 ], function(Origin, Helpers, Schemas, BackboneForms, BackboneFormsLists, Overrides, ScaffoldAssetView, ScaffoldAssetItemView, ScaffoldCodeEditorView, ScaffoldColourPickerView, ScaffoldDisplayTitleView, ScaffoldItemsModalView, ScaffoldListView, ScaffoldTagsView, ScaffoldUsersView) {
 
   var Scaffold = {};
-  var builtSchemas = {};
   var alternativeModel;
   var alternativeAttribute;
   var currentModel;
@@ -32,7 +31,6 @@ define([
 
   function onScaffoldUpdateSchemas(callback, context) {
     Origin.trigger('schemas:loadData', function() {
-      builtSchemas = {};
       callback.apply(context);
     });
   }
@@ -146,20 +144,6 @@ define([
   }
 
   function buildSchema(schema, options, type) {
-    // these types of schemas change frequently and cannot be cached
-    var isVolatileType = _.contains([
-      'course',
-      'config',
-      'article',
-      'block',
-      'component'
-    ], type);
-
-    var builtSchema = builtSchemas[type];
-
-    if (!isVolatileType && builtSchema) {
-      return builtSchema;
-    }
 
     var scaffoldSchema = {};
 
@@ -181,11 +165,6 @@ define([
       }
     }
 
-    // only cache non-volatile types
-    if (!isVolatileType) {
-      builtSchemas[type] = scaffoldSchema;
-    }
-
     return scaffoldSchema;
   }