Skip to content

Commit 06a5f2b

Browse files
committed
Merge branch 'ci-fix-and-drop-v8-6.5' into 'master'
Noissue - fix the usage of correct URL_PREFIX for CI and drop V8 6.5 from CI See merge request eyeo/adblockplus/libadblockplus!16
2 parents ed692a2 + 8b9594a commit 06a5f2b

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

.travis.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,13 @@ python: '2.7'
1818

1919
env:
2020
global:
21-
- URL_PREFIX=https://v8.eyeofiles.com/v8-${!V8_COMMIT}/
21+
- URL_PREFIX_PREFIX=https://v8.eyeofiles.com/v8- # add V8_COMMIT
2222
- ANDROID_NDK_ROOT=${TRAVIS_BUILD_DIR}/third_party/android-ndk-r16b
2323
- libv8_show_warnings="true"
2424
matrix:
2525
# 6.7.288.11
2626
- V8_COMMIT=4fc9a2fe7f8a7ef1e7966185b39b3b541792669a ABP_OS_SCRIPT=nix
2727
- V8_COMMIT=4fc9a2fe7f8a7ef1e7966185b39b3b541792669a ABP_OS_SCRIPT=android
28-
# https://github.com/adblockplus/v8-googlesource/commit/3cdaf01c4043e19965efc5ef48df5314960b898f
29-
# 6.5.254.41
30-
- V8_COMMIT=3cdaf01c4043e19965efc5ef48df5314960b898f ABP_OS_SCRIPT=nix
31-
- V8_COMMIT=3cdaf01c4043e19965efc5ef48df5314960b898f ABP_OS_SCRIPT=android
3228

3329
matrix:
3430
exclude:
@@ -44,6 +40,7 @@ before_script:
4440
- if [[ "${ABP_OS_SCRIPT}" == "android" && "$TRAVIS_OS_NAME" == "linux" ]]; then wget https://dl.google.com/android/repository/android-ndk-r16b-linux-x86_64.zip -O third_party/android-ndk.zip ; fi
4541
- if [[ "${ABP_OS_SCRIPT}" == "android" && "$TRAVIS_OS_NAME" == "osx" ]]; then wget https://dl.google.com/android/repository/android-ndk-r16b-darwin-x86_64.zip -O third_party/android-ndk.zip ; fi
4642
- if [[ "${ABP_OS_SCRIPT}" == "android" ]]; then unzip -q third_party/android-ndk.zip -d third_party/ ; fi
43+
- export URL_PREFIX=${URL_PREFIX_PREFIX}${V8_COMMIT}/
4744

4845
script:
4946
- bash ./.travis/${ABP_OS_SCRIPT}-script.sh

Makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ endif
5858

5959
TEST_EXECUTABLE = ${BUILD_DIR}/out/Debug/tests
6060

61+
URL_PREFIX ?= "https://v8.eyeofiles.com/v8-4fc9a2fe7f8a7ef1e7966185b39b3b541792669a/"
62+
6163
.PHONY: all test clean docs ensure_dependencies
6264

6365
.DEFAULT_GOAL:=all
@@ -76,7 +78,7 @@ docs:
7678
doxygen
7779

7880
get-prebuilt-v8:
79-
URL_PREFIX="https://v8.eyeofiles.com/v8-4fc9a2fe7f8a7ef1e7966185b39b3b541792669a/" \
81+
URL_PREFIX=${URL_PREFIX} \
8082
TARGET_OS=${TARGET_OS} ABP_TARGET_ARCH=${ABP_TARGET_ARCH} \
8183
TRAVIS_OS_NAME=${TRAVIS_OS_NAME} Configuration=${Configuration} \
8284
bash .travis/prepare-prebuilt-v8.sh

0 commit comments

Comments
 (0)