Merge branch 'issue-6526' into 'master'

Issue 6526 - show warnings about deprecated V8 API

See merge request eyeo/adblockplus/libadblockplus!6

Author: xxxz

.travis.yml

@@ -24,6 +24,7 @@ env:
   global:
   - URL_PREFIX=https://v8.eyeofiles.com/v8-4fc9a2fe7f8a7ef1e7966185b39b3b541792669a/
   - ANDROID_NDK_ROOT=${TRAVIS_BUILD_DIR}/third_party/android-ndk-r16b
+  - libv8_show_warnings="true"
   matrix:
   - BUILD_ACTION=test
   - BUILD_ACTION=all TARGET_OS=android Configuration=release ABP_TARGET_ARCH=arm

Makefile

@@ -51,7 +51,7 @@ endif
 
 GYP_PARAMETERS=host_arch=${HOST_ARCH} OS=${TARGET_OS} target_arch=${ABP_TARGET_ARCH}
 ifneq "$(and ${LIBV8_LIB_DIR}, ${LIBV8_INCLUDE_DIR})" ""
-GYP_PARAMETERS+= libv8_lib_dir=${LIBV8_LIB_DIR} libv8_include_dir=${LIBV8_INCLUDE_DIR}
+GYP_PARAMETERS+= libv8_lib_dir=${LIBV8_LIB_DIR} libv8_include_dir=${LIBV8_INCLUDE_DIR} libv8_show_warnings=${libv8_show_warnings}
 else
 $(error "V8 directories are not specified")
 endif

README.md

@@ -313,3 +313,8 @@ You can lint the code using [ESLint](http://eslint.org).
 In order to set up ESLint and
 [configuration eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-config-eyeo) you need [Node.js 7 or higher](https://nodejs.org/) and once it is installed please run `npm install` in the repository directory.
 
+In order to learn about the usage of deprecated V8 API please set `libv8_show_warnings` to `"true"` on *nix, e.g.
+
+    make libv8_show_warnings="true"
+
+or on Windows add it to `GYP_DEFINES`.

appveyor.yml

@@ -18,7 +18,7 @@ install:
 environment:
   URL_PREFIX: https://v8.eyeofiles.com/v8-4fc9a2fe7f8a7ef1e7966185b39b3b541792669a/
 before_build:
-- cmd: set "GYP_DEFINES=libv8_include_dir=third_party/prebuilt-v8/include libv8_lib_dir=../../third_party/prebuilt-v8"
+- cmd: set "GYP_DEFINES=libv8_include_dir=third_party/prebuilt-v8/include libv8_lib_dir=../../third_party/prebuilt-v8 libv8_show_warnings=true"
 - cmd: createsolution.bat
 - cmd: >-
     if "%Platform%"=="Win32" set arch="ia32"

v8.gypi

@@ -15,4 +15,14 @@
       }]
     ]
   },
+  'target_defaults': {
+    'conditions': [[
+      'libv8_show_warnings=="true"', {
+        'defines': [
+          'V8_DEPRECATION_WARNINGS',
+          'V8_IMMINENT_DEPRECATION_WARNINGS'
+        ]
+      }
+    ]]
+  }
 }