Skip to content

Commit 322dada

Browse files
committed
Merge branch 'ci-update-v8-6.9' into 'master'
Noissue - update CI to use V8 6.9 See merge request eyeo/adblockplus/libadblockplus!19
2 parents 469f2d5 + e49ccee commit 322dada

5 files changed

Lines changed: 14 additions & 7 deletions

File tree

.travis.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,19 @@ env:
2222
- ANDROID_NDK_ROOT=${TRAVIS_BUILD_DIR}/third_party/android-ndk-r16b
2323
- libv8_show_warnings="true"
2424
matrix:
25+
# 6.9.427.22
26+
- V8_COMMIT=9a7be49a7a6e435d8a7d435c4879340a3cc7524c ABP_OS_SCRIPT=nix
27+
- V8_COMMIT=9a7be49a7a6e435d8a7d435c4879340a3cc7524c ABP_OS_SCRIPT=android
2528
# 6.7.288.11
2629
- V8_COMMIT=4fc9a2fe7f8a7ef1e7966185b39b3b541792669a ABP_OS_SCRIPT=nix
2730
- V8_COMMIT=4fc9a2fe7f8a7ef1e7966185b39b3b541792669a ABP_OS_SCRIPT=android
2831

2932
matrix:
3033
exclude:
3134
- os: linux
32-
env: V8_COMMIT=4fc9a2fe7f8a7ef1e7966185b39b3b541792669a ABP_OS_SCRIPT=nix
35+
env: V8_COMMIT=9a7be49a7a6e435d8a7d435c4879340a3cc7524c ABP_OS_SCRIPT=nix
3336
- os: linux
34-
env: V8_COMMIT=3cdaf01c4043e19965efc5ef48df5314960b898f ABP_OS_SCRIPT=nix
37+
env: V8_COMMIT=4fc9a2fe7f8a7ef1e7966185b39b3b541792669a ABP_OS_SCRIPT=nix
3538

3639
before_script:
3740
- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew update; fi

.travis/prepare-prebuilt-v8.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ if [[ "${TARGET_OS}" != "android" ]]; then
1111
if [[ "${TRAVIS_OS_NAME}" == "osx" ]]; then
1212
PREBUILT_V8_ARCHIVE=osx-x64-debug.tar.xz
1313
elif [[ "${TRAVIS_OS_NAME}" == "linux" ]]; then
14-
PREBUILT_V8_ARCHIVE=u14.04-x64-debug.tar.xz
14+
PREBUILT_V8_ARCHIVE=u18.04-x64-debug.tar.xz
1515
fi
1616
fi
1717

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ endif
5858

5959
TEST_EXECUTABLE = ${BUILD_DIR}/out/Debug/tests
6060

61-
URL_PREFIX ?= "https://v8.eyeofiles.com/v8-4fc9a2fe7f8a7ef1e7966185b39b3b541792669a/"
61+
URL_PREFIX ?= "https://v8.eyeofiles.com/v8-$(shell sed -nE 's/.*V8_COMMIT=([^\s]+) .*/\1/p' .travis.yml|head -n1)/"
6262

6363
.PHONY: all test clean docs ensure_dependencies
6464

appveyor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ install:
2323

2424
environment:
2525
global:
26-
URL_PREFIX: https://v8.eyeofiles.com/v8-4fc9a2fe7f8a7ef1e7966185b39b3b541792669a/
26+
URL_PREFIX: https://v8.eyeofiles.com/v8-9a7be49a7a6e435d8a7d435c4879340a3cc7524c/
2727
matrix:
2828
- APPVEYOR_BUILD_WORKER_IMAGE: ubuntu
2929
Configuration: Debug

common.gypi

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,14 @@
1515
# See https://issues.adblockplus.org/ticket/4950
1616
# We might be able to do without after upgrading V8.
1717
'cflags_cc': [ '-fno-rtti', '-std=c++14', '-fexceptions', '-fpermissive', '-stdlib=libc++' ],
18-
'cflags!': [ '-Werror', ],
19-
'ldflags': [ '-pthread', ],
18+
'ldflags': [ '-pthread'],
2019
},
2120
}],
21+
['OS=="linux"', {
22+
'target_defaults': {
23+
'ldflags': ['-lc++']
24+
}
25+
}],
2226
['OS=="mac"', {
2327
'xcode_settings': {
2428
'CLANG_CXX_LANGUAGE_STANDARD': 'c++14',

0 commit comments

Comments
 (0)