From 3d5f4a2b05fd349c1d8d796a13987a2d06ee043a Mon Sep 17 00:00:00 2001 From: Shazron Abdullah <36107+shazron@users.noreply.github.com> Date: Mon, 13 Apr 2026 19:49:48 +0800 Subject: [PATCH 1/2] fix: remove return value from fingerprint command Commands should not return values; output is already logged via this.log(). Co-Authored-By: Claude Sonnet 4.6 --- src/commands/certificate/fingerprint.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/commands/certificate/fingerprint.js b/src/commands/certificate/fingerprint.js index 0678c45..af78d5b 100644 --- a/src/commands/certificate/fingerprint.js +++ b/src/commands/certificate/fingerprint.js @@ -31,7 +31,6 @@ class FingerprintCommand extends Command { const res = cert.fingerprint(pemCert) this.log(res.certificateFingerprint) - return res.certificateFingerprint } catch (err) { debug('error fingerprinting certificate: ', err) this.error(err.message) From 8bde543ed7af0513d3cfdc22e6425fb000047b78 Mon Sep 17 00:00:00 2001 From: Shazron Abdullah <36107+shazron@users.noreply.github.com> Date: Mon, 13 Apr 2026 19:53:27 +0800 Subject: [PATCH 2/2] fix: update fingerprint test to not expect a return value Co-Authored-By: Claude Sonnet 4.6 --- test/commands/certificate/fingerprint.test.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/commands/certificate/fingerprint.test.js b/test/commands/certificate/fingerprint.test.js index af05fff..01762e3 100644 --- a/test/commands/certificate/fingerprint.test.js +++ b/test/commands/certificate/fingerprint.test.js @@ -116,7 +116,9 @@ describe('instance methods - real forge', () => { mockFS.existsSync.mockReturnValue(true) mockFS.readFileSync.mockReturnValue(Buffer.from(validCertPem)) command.argv = ['file'] - await expect(command.run()).resolves.toBe(validCertFingerprint) + const logSpy = jest.spyOn(command, 'log') + await expect(command.run()).resolves.toBeUndefined() + expect(logSpy).toHaveBeenCalledWith(validCertFingerprint) expect(handleError).not.toHaveBeenCalled() }) })