Skip to content

Commit 457e7ae

Browse files
authored
Fix(Git ignorecase=false): keep default_PDF.pdf, remove default_pdf.pdf (#947)
# Description ## Summary <!--BRIEF description: DONT'T EXPLAIN the code: JUSTIFY what this PR is for!--> That damn PDF breaks my local repo bc it conflicts with my global `ignorecase = false` git config ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> - [x] `rm default_pdf.pdf` (used once vs thrice for `default_PDF.pdf`) - [ ] use only `default_PDF.pdf` in the codebase <!--Don't touch thses two tags--> <details> <summary> # Classification </summary> ## Type of Change - [x] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (non-breaking change which adds functionality) - [ ] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [x] 😶‍🌫️ No impact for the end-users ## Impact & Scope - [ ] Core functionality changes - [ ] Single module changes - [ ] Multiple modules changes - [ ] Database migrations required - [x] Other: <!--Not module-oriented: write something!--> ## Testing - [x] 1. Tested this locally - [ ] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [ ] 3. Tested in a deployed pre-prod - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `"` Docstrings - [ ] `#` Inline comments - [x] No documentation needed </details>
1 parent fc71819 commit 457e7ae

2 files changed

Lines changed: 1 addition & 1 deletion

File tree

assets/pdf/default_pdf.pdf

-120 KB
Binary file not shown.

tests/core/test_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ async def test_save_pdf_first_page_as_image() -> None:
244244
input_pdf_directory="test/pdf",
245245
output_image_directory="test/image",
246246
filename=valid_uuid,
247-
default_pdf_path="assets/pdf/default_pdf.pdf",
247+
default_pdf_path="assets/pdf/default_PDF.pdf",
248248
)
249249
assert Path(f"data/test/image/{valid_uuid}.jpg").is_file()
250250

0 commit comments

Comments
 (0)