Updates

Author: benbrandt

docs/protocol/draft/schema.mdx

@@ -1134,39 +1134,6 @@ See protocol docs: [Extensibility](https://agentclientprotocol.com/protocol/exte
 
 </ResponseField>
 
-<a id="notifications-elicitation-complete"></a>
-### <span class="font-mono">notifications/elicitation/complete</span>
-
-**UNSTABLE**
-
-This capability is not part of the spec yet, and may be removed or changed at any point.
-
-Notification that a URL-based elicitation has completed.
-
-#### <span class="font-mono">ElicitationCompleteNotification</span>
-
-**UNSTABLE**
-
-This capability is not part of the spec yet, and may be removed or changed at any point.
-
-Notification sent by the agent when a URL-based elicitation is complete.
-
-**Type:** Object
-
-**Properties:**
-
-<ResponseField name="_meta" type={"object | null"} >
-  The _meta property is reserved by ACP to allow clients and agents to attach additional
-metadata to their interactions. Implementations MUST NOT make assumptions about values at
-these keys.
-
-See protocol docs: [Extensibility](https://agentclientprotocol.com/protocol/extensibility)
-
-</ResponseField>
-<ResponseField name="elicitationId" type={<a href="#elicitationid">ElicitationId</a>} required>
-  The ID of the elicitation that completed.
-</ResponseField>
-
 <a id="session-elicitation"></a>
 ### <span class="font-mono">session/elicitation</span>
 
@@ -1250,6 +1217,39 @@ See protocol docs: [Extensibility](https://agentclientprotocol.com/protocol/exte
   The user's action in response to the elicitation.
 </ResponseField>
 
+<a id="session-elicitation-complete"></a>
+### <span class="font-mono">session/elicitation/complete</span>
+
+**UNSTABLE**
+
+This capability is not part of the spec yet, and may be removed or changed at any point.
+
+Notification that a URL-based elicitation has completed.
+
+#### <span class="font-mono">ElicitationCompleteNotification</span>
+
+**UNSTABLE**
+
+This capability is not part of the spec yet, and may be removed or changed at any point.
+
+Notification sent by the agent when a URL-based elicitation is complete.
+
+**Type:** Object
+
+**Properties:**
+
+<ResponseField name="_meta" type={"object | null"} >
+  The _meta property is reserved by ACP to allow clients and agents to attach additional
+metadata to their interactions. Implementations MUST NOT make assumptions about values at
+these keys.
+
+See protocol docs: [Extensibility](https://agentclientprotocol.com/protocol/extensibility)
+
+</ResponseField>
+<ResponseField name="elicitationId" type={<a href="#elicitationid">ElicitationId</a>} required>
+  The ID of the elicitation that completed.
+</ResponseField>
+
 <a id="session-request_permission"></a>
 ### <span class="font-mono">session/request_permission</span>
 

schema/meta.unstable.json

@@ -18,8 +18,8 @@
   "clientMethods": {
     "fs_read_text_file": "fs/read_text_file",
     "fs_write_text_file": "fs/write_text_file",
-    "notification_elicitation_complete": "notifications/elicitation/complete",
     "session_elicitation": "session/elicitation",
+    "session_elicitation_complete": "session/elicitation/complete",
     "session_request_permission": "session/request_permission",
     "session_update": "session/update",
     "terminal_create": "terminal/create",

schema/schema.unstable.json

@@ -1554,7 +1554,7 @@
       },
       "required": ["elicitationId"],
       "type": "object",
-      "x-method": "notifications/elicitation/complete",
+      "x-method": "session/elicitation/complete",
       "x-side": "client"
     },
     "ElicitationFormCapabilities": {

src/bin/generate.rs

@@ -965,7 +965,7 @@ starting with '$/' it is free to ignore the notification."
                 #[cfg(feature = "unstable_elicitation")]
                 "session/elicitation" => self.client.get("ElicitationRequest").unwrap(),
                 #[cfg(feature = "unstable_elicitation")]
-                "notifications/elicitation/complete" => {
+                "session/elicitation/complete" => {
                     self.client.get("ElicitationCompleteNotification").unwrap()
                 }
                 _ => panic!("Introduced a method? Add it here :)"),

src/client.rs

@@ -966,7 +966,7 @@ impl ElicitationRequest {
 ///
 /// The mode of elicitation, determining how user input is collected.
 #[cfg(feature = "unstable_elicitation")]
-#[derive(Debug, Clone, Serialize, Deserialize, JsonSchema, PartialEq)]
+#[derive(Debug, Clone, Serialize, Deserialize, JsonSchema, PartialEq, Eq)]
 #[serde(tag = "mode", rename_all = "snake_case")]
 #[schemars(extend("discriminator" = {"propertyName": "mode"}))]
 #[non_exhaustive]