Skip to content

Commit 7752cec

Browse files
tercelclaude
andcommitted
docs(planning): replace pre-commit-blocked Greek + CJK chars
The apdev check-chars pre-commit hook blocks specific character ranges (Greek, CJK) even though it allows common typographic chars (em-dash, arrow, section sign). Two illegal chars in the cleanup-2026-04 final summary: - 'Δ' table column header → 'Diff' - '全部解决' inside a quoted phrase → 'solve everything' Project policy (CLAUDE.md) is English-only for committed text anyway, so the planning doc shouldn't have CJK. The em-dashes, arrows, and section signs elsewhere in the planning docs and CHANGELOG remain because the hook explicitly allows them. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 76cfb33 commit 7752cec

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

planning/cleanup-2026-04-final-summary.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
## Impact on Files Touched
3232

33-
| File | Before | After | Δ |
33+
| File | Before | After | Diff |
3434
|---|---:|---:|---:|
3535
| executor.py | 1057 | 874 | **−183** |
3636
| builtin_steps.py | 817 | 858 | +41 |
@@ -102,7 +102,7 @@ When the next cleanup round happens, the following items should be re-investigat
102102

103103
The shallow alternative (auto-wrap legacy yaml in `{"apcore": ...}` at load time) was also rejected: it would break the same 10 test files via `config.data` shape contract AND wouldn't actually unify validate/env-override because their algorithms still differ. Marginal helper extraction (`_run_constraints_check`) was also rejected as premature abstraction (saves 0 LOC).
104104

105-
**Bottom line**: This is genuinely deferred to a future round with proper design upfront. The cleanup-2026-04 round explicitly chose NOT to attempt this refactor under "全部解决" pressure because the risk-to-value ratio was wrong.
105+
**Bottom line**: This is genuinely deferred to a future round with proper design upfront. The cleanup-2026-04 round explicitly chose NOT to attempt this refactor under "solve everything" pressure because the risk-to-value ratio was wrong.
106106
2. **`registry.py:_handle_file_change`** — Class discovery via `dir(mod)` + `hasattr(attr, 'execute')` is fragile and inconsistent with the entry_point resolution that the rest of the registry uses. Not in this round's scope but flagged for cleanup.
107107
3. **`builtin_steps.py:692-857` strategy builder duplication** — Five build_*_strategy functions all do `build_standard_strategy + .remove() + name = X`. Could be data-driven (`{name: [removed_steps]}` table). Skipped this round to avoid premature abstraction; revisit if a 6th strategy variant is added.
108108
4. **`pipeline_config.py` `register_step_type()`** — Agent reported zero production callers. Not verified yet. If genuinely unused, delete the dynamic-handler-resolution path.

0 commit comments

Comments
 (0)