fix: resolve small linting and typing issues

Author: akhundMurad

tests/explain/test_cli_yaml.py

@@ -7,7 +7,6 @@
 from typeid import TypeID
 from typeid.cli import cli
 
-
 yaml = pytest.importorskip("yaml")  # skip if PyYAML not installed
 
 

tests/explain/test_registry_yaml.py

@@ -4,7 +4,6 @@
 
 from typeid.explain.registry import load_registry
 
-
 yaml = pytest.importorskip("yaml")  # skip entire file if PyYAML is not installed
 
 

typeid/cli.py

@@ -1,12 +1,12 @@
+from pathlib import Path
 from typing import Optional
 
 import click
 from uuid6 import UUID
 
 from typeid import TypeID, base32, from_uuid, get_prefix_and_suffix
-
-from typeid.explain.engine import explain as explain_engine
 from typeid.explain.discovery import discover_schema_path
+from typeid.explain.engine import explain as explain_engine
 from typeid.explain.formatters import format_explanation_json, format_explanation_pretty
 from typeid.explain.registry import load_registry, make_lookup
 
@@ -49,7 +49,7 @@ def decode(encoded: str) -> None:
     type=click.Path(exists=True, dir_okay=False, path_type=str),
     required=False,
     help="Path to TypeID schema file (JSON, or YAML if PyYAML is installed). "
-         "If omitted, TypeID will try to discover a schema automatically.",
+    "If omitted, TypeID will try to discover a schema automatically.",
 )
 @click.option(
     "--json",
@@ -98,10 +98,6 @@ def explain(
             # we keep CLI robust and simply proceed without schema.
 
         if resolved_path:
-            result = load_registry(click.Path(resolved_path))
-            # NOTE: click.Path is not a real filesystem path. Convert to pathlib Path.
-            # We'll do it safely:
-            from pathlib import Path
             result = load_registry(Path(resolved_path))
 
             if result.registry is not None:

typeid/explain/__init__.py

@@ -18,10 +18,10 @@
 from pathlib import Path
 from typing import Optional
 
-from .engine import explain as _explain_engine
-from .registry import load_registry, make_lookup
 from .discovery import discover_schema_path
+from .engine import explain as _explain_engine
 from .model import Explanation
+from .registry import load_registry, make_lookup
 
 __all__ = [
     "explain",

typeid/explain/discovery.py

@@ -22,7 +22,6 @@
 from pathlib import Path
 from typing import Iterable, Optional
 
-
 DEFAULT_CWD_CANDIDATES = (
     "typeid.schema.json",
     "typeid.schema.yaml",
@@ -39,6 +38,7 @@
 @dataclass(frozen=True, slots=True)
 class DiscoveryResult:
     """Result of schema discovery."""
+
     path: Optional[Path]
     source: str  # e.g., "env:TYPEID_SCHEMA", "cwd", "user_config", "none"
 
@@ -69,7 +69,7 @@ def discover_schema_path(
         return DiscoveryResult(path=None, source=f"env:{env_var} (not found)")
 
     # 2) Current working directory
-    cwd_path = (cwd or Path.cwd())
+    cwd_path = cwd or Path.cwd()
     for name in DEFAULT_CWD_CANDIDATES:
         p = cwd_path / name
         if p.is_file():
@@ -117,7 +117,7 @@ def iter_default_candidate_paths(*, cwd: Optional[Path] = None) -> Iterable[Path
 
     Useful for debugging or `typeid explain --debug-discovery` style features.
     """
-    cwd_path = (cwd or Path.cwd())
+    cwd_path = cwd or Path.cwd()
     for name in DEFAULT_CWD_CANDIDATES:
         yield cwd_path / name
 

typeid/explain/engine.py

@@ -19,8 +19,7 @@
 from typeid import TypeID
 from typeid.errors import TypeIDException
 
-from .model import Explanation, ParseError, ParsedTypeID, Provenance, TypeSchema
-
+from .model import Explanation, ParsedTypeID, ParseError, Provenance, TypeSchema
 
 SchemaLookup = Callable[[str], Optional[TypeSchema]]
 
@@ -183,6 +182,7 @@ def _uuid7_created_at(uuid_obj: Any) -> Optional[datetime]:
 
 class _SafeFormatDict(dict):
     """dict that leaves unknown placeholders intact instead of raising KeyError."""
+
     def __missing__(self, key: str) -> str:
         return "{" + key + "}"
 

typeid/explain/formatters.py

@@ -118,6 +118,7 @@ def format_explanation_json(exp: Explanation, *, indent: int = 2) -> str:
 
 class SafeFormatDict(dict):
     """dict that leaves unknown placeholders intact rather than raising KeyError."""
+
     def __missing__(self, key: str) -> str:
         return "{" + key + "}"
 

typeid/explain/model.py

@@ -16,6 +16,7 @@
 
 class Provenance(str, Enum):
     """Where a piece of information came from."""
+
     DERIVED_FROM_ID = "derived_from_id"
     SCHEMA = "schema"
     EXTERNAL = "external"
@@ -25,6 +26,7 @@ class Provenance(str, Enum):
 @dataclass(frozen=True, slots=True)
 class ParseError:
     """Represents a recoverable parse/validation error."""
+
     code: str
     message: str
 
@@ -39,6 +41,7 @@ class ParsedTypeID:
     - `suffix` is the encoded UUIDv7 portion (base32 string).
     - `uuid` and `created_at` are *derived* from suffix if possible.
     """
+
     raw: str
     prefix: Optional[str]
     suffix: Optional[str]
@@ -61,6 +64,7 @@ class TypeSchema:
     breaking the Python API: we store raw dict and also normalize a few
     commonly-used fields for nicer UX.
     """
+
     prefix: str
     raw: Dict[str, Any] = field(default_factory=dict)
 
@@ -87,6 +91,7 @@ class Explanation:
     - links: rendered links (from schema templates), safe for display
     - provenance: per-field provenance labels for transparency
     """
+
     id: str
     valid: bool
 

typeid/explain/registry.py

@@ -54,6 +54,7 @@ class SchemaRegistry:
 
     Lookup is by full TypeID prefix (which may contain underscores).
     """
+
     def __init__(self, *, schema_version: int, types: Dict[str, TypeSchema], source_path: Path):
         self.schema_version = schema_version
         self._types = types
@@ -145,10 +146,12 @@ def make_lookup(registry: Optional[SchemaRegistry]):
         lookup = make_lookup(reg)
         explanation = explain(id, schema_lookup=lookup)
     """
+
     def _lookup(prefix: str) -> Optional[TypeSchema]:
         if registry is None:
             return None
         return registry.get(prefix)
+
     return _lookup
 
 
@@ -183,8 +186,10 @@ def _read_schema_file(path: Path) -> Tuple[Dict[str, Any], str]:
     # If extension unknown, try JSON first for convenience.
     try:
         return json.loads(raw), "json"
-    except Exception:
-        raise RuntimeError(f"Unsupported schema file extension: {path.suffix!s} (supported: .json, .yaml, .yml)")
+    except Exception as e:
+        raise RuntimeError(
+            f"Unsupported schema file extension: {path.suffix!s} (supported: .json, .yaml, .yml)"
+        ) from e
 
 
 def _to_type_schema(prefix: str, spec: Dict[str, Any]) -> TypeSchema: