loader tests

Author: Alex Ross

segment.js

@@ -49,27 +49,23 @@ angular.module('ngSegment').constant('segmentDefaultConfig', {
 
 (function (module) {
 
-    var hasLoaded = false;
+    function SegmentLoader(hasLoaded) {
 
-    function SegmentLoader() {
-
-        this.hasLoaded = function () {
-            return hasLoaded;
-        };
+        this.hasLoaded = hasLoaded || false;
 
         this.load = function (apiKey, delayMs) {
 
-            // Warn if analytics.js has already been loaded, because it most likely
+            // If analytics.js has already been loaded, it most likely
             // means the user has made an error
-            if (hasLoaded || window.analytics.initialized) {
-                console.warn('Attempting to load Segment twice.');
+            if (this.hasLoaded || window.analytics.initialized) {
+                throw new Error('Attempting to load Segment twice.');
             } else {
 
                 // Only load if we've been given or have set an API key
                 if (apiKey) {
 
                     // Prevent double .load() calls
-                    hasLoaded = true;
+                    this.hasLoaded = true;
 
                     window.setTimeout(function () {
 
@@ -91,7 +87,7 @@ angular.module('ngSegment').constant('segmentDefaultConfig', {
                         first.parentNode.insertBefore(script, first);
                     }, delayMs);
                 } else {
-                    throw new Error('Cannot load Analytics.js without an API key');
+                    throw new Error('Cannot load Analytics.js without an API key.');
                 }
             }
         };
@@ -103,7 +99,7 @@ angular.module('ngSegment').constant('segmentDefaultConfig', {
         SegmentLoader.call(this);
 
         this.$get = function () {
-            return new SegmentLoader();
+            return new SegmentLoader(this.hasLoaded);
         };
     }
 

segment.min.js

@@ -1,26 +1,22 @@
 (function (module) {
 
-    var hasLoaded = false;
+    function SegmentLoader(hasLoaded) {
 
-    function SegmentLoader() {
-
-        this.hasLoaded = function () {
-            return hasLoaded;
-        };
+        this.hasLoaded = hasLoaded || false;
 
         this.load = function (apiKey, delayMs) {
 
-            // Warn if analytics.js has already been loaded, because it most likely
+            // If analytics.js has already been loaded, it most likely
             // means the user has made an error
-            if (hasLoaded || window.analytics.initialized) {
-                console.warn('Attempting to load Segment twice.');
+            if (this.hasLoaded || window.analytics.initialized) {
+                throw new Error('Attempting to load Segment twice.');
             } else {
 
                 // Only load if we've been given or have set an API key
                 if (apiKey) {
 
                     // Prevent double .load() calls
-                    hasLoaded = true;
+                    this.hasLoaded = true;
 
                     window.setTimeout(function () {
 
@@ -42,7 +38,7 @@
                         first.parentNode.insertBefore(script, first);
                     }, delayMs);
                 } else {
-                    throw new Error('Cannot load Analytics.js without an API key');
+                    throw new Error('Cannot load Analytics.js without an API key.');
                 }
             }
         };
@@ -54,7 +50,7 @@
         SegmentLoader.call(this);
 
         this.$get = function () {
-            return new SegmentLoader();
+            return new SegmentLoader(this.hasLoaded);
         };
     }
 

src/loader.js

@@ -1,14 +1,34 @@
 describe('segmentLoader', function () {
     'use strict';
 
-    beforeEach(module('ngSegment'));
+    beforeEach(function () {
+        module('ngSegment');
+        window.analytics.initialized = false;
+    });
 
     it('should require an API key to load Analytics.js', function () {
-
+        inject(function (segmentLoader) {
+            var error = new Error('Cannot load Analytics.js without an API key.');
+            expect(segmentLoader.load).toThrow(error);
+        });
     });
 
     it('should not allow loading Analytics.js twice', function () {
+        inject(function (segmentLoader) {
+            segmentLoader.load('abc');
+            expect(function () {
+                segmentLoader.load('abc');
+            }).toThrow(new Error('Attempting to load Segment twice.'));
+        });
+    });
 
+    it('should not allow loading Analytics.js if it has already been included', function () {
+        inject(function (segment, segmentLoader) {
+            window.analytics.initialized = true;
+            expect(function () {
+                segmentLoader.load('abc');
+            }).toThrow(new Error('Attempting to load Segment twice.'));
+        });
     });
 
     it('should not load Analytics.js automatically if autoload is not enabled', function () {
@@ -17,7 +37,7 @@ describe('segmentLoader', function () {
         });
 
         inject(function (segment, segmentLoader) {
-            expect(segmentLoader.hasLoaded()).toEqual(false);
+            expect(segmentLoader.hasLoaded).toEqual(false);
         });
     });
 });