Translate WSL paths for Windows runtimes

Author: FolderView Plus Test

scripts/dev_finalize.sh

@@ -74,7 +74,7 @@ fvplus::require_commands bash node git
 NODE_BIN="$(fvplus::resolve_platform_command node)"
 
 if [[ "${OPEN_FIXTURE}" == true ]]; then
-    "${NODE_BIN}" scripts/generate_runtime_fixture.mjs
+    "${NODE_BIN}" "$(fvplus::path_for_command "${NODE_BIN}" "scripts/generate_runtime_fixture.mjs")"
 fi
 
 bash scripts/doctor.sh

scripts/install_smoke.sh

@@ -156,11 +156,13 @@ for required_file in "${REQUIRED_FILES[@]}"; do
 done
 
 while IFS= read -r -d '' file; do
-  "${PHP_BIN}" -l "${file}" >/dev/null
+  php_target="$(fvplus::path_for_command "${PHP_BIN}" "${file}")"
+  "${PHP_BIN}" -l "${php_target}" >/dev/null
 done < <(find "${PLUGIN_DIR}/server" -type f -name "*.php" -print0)
 
 while IFS= read -r -d '' file; do
-  "${NODE_BIN}" --check "${file}" >/dev/null
+  node_target="$(fvplus::path_for_command "${NODE_BIN}" "${file}")"
+  "${NODE_BIN}" --check "${node_target}" >/dev/null
 done < <(find "${PLUGIN_DIR}/scripts" -type f -name "*.js" ! -path "*/scripts/include/*" -print0)
 
 MUTATING_ENDPOINTS=(

scripts/lib.sh

@@ -20,6 +20,22 @@ fvplus::resolve_platform_command() {
   return 1
 }
 
+fvplus::path_for_command() {
+  local command_path="${1:-}"
+  local target_path="${2:-}"
+  local normalized_path=""
+  [[ -n "${target_path}" ]] || return 1
+  if [[ "${command_path}" == *.exe ]] && command -v wslpath >/dev/null 2>&1; then
+    normalized_path="${target_path}"
+    if [[ "${normalized_path}" != /* && ! "${normalized_path}" =~ ^[A-Za-z]:[\\/].* ]]; then
+      normalized_path="$(realpath -m "${normalized_path}" 2>/dev/null || printf '%s/%s' "$(pwd)" "${normalized_path}")"
+    fi
+    wslpath -w "${normalized_path}"
+    return 0
+  fi
+  printf '%s\n' "${target_path}"
+}
+
 fvplus::require_commands() {
   local missing=()
   local cmd

scripts/release_guard.sh

@@ -152,6 +152,7 @@ if command -v xmllint >/dev/null 2>&1; then
   xmllint --noout "${PLG_FILE}"
 else
   PHP_BIN="$(resolve_php_bin)"
+  PLG_VALIDATE_PATH="$(fvplus::path_for_command "${PHP_BIN}" "${PLG_FILE}")"
   # shellcheck disable=SC2016
   "${PHP_BIN}" -r '
       libxml_use_internal_errors(true);
@@ -162,7 +163,7 @@ else
           fwrite(STDERR, "ERROR: Invalid PLG XML\n");
           exit(1);
       }
-  ' "${PLG_FILE}"
+  ' "${PLG_VALIDATE_PATH}"
 fi
 
 ARCHIVE_FILE="${ARCHIVE_DIR}/folderview.plus-${VERSION}.txz"

scripts/run_ci_suite.sh

@@ -144,16 +144,20 @@ lint_shell_scripts() {
 lint_javascript_syntax() {
   mapfile -d '' files < <(find src -type f -name "*.js" ! -path "*/scripts/include/*" -print0)
   local file=""
+  local target=""
   for file in "${files[@]}"; do
-    "${NODE_BIN}" --check "${file}"
+    target="$(fvplus::path_for_command "${NODE_BIN}" "${file}")"
+    "${NODE_BIN}" --check "${target}"
   done
 }
 
 lint_php_syntax() {
   mapfile -d '' files < <(find src -type f -name "*.php" -print0)
   local file=""
+  local target=""
   for file in "${files[@]}"; do
-    "${PHP_BIN}" -l "${file}"
+    target="$(fvplus::path_for_command "${PHP_BIN}" "${file}")"
+    "${PHP_BIN}" -l "${target}"
   done
 }
 
@@ -188,8 +192,8 @@ run_lane() {
       run_timed_step shellcheck lint_shell_scripts
       run_timed_step javascript-syntax lint_javascript_syntax
       run_timed_step php-syntax lint_php_syntax
-      run_timed_step javascript-unused-symbols "${NODE_BIN}" scripts/js_unused_symbols_guard.mjs
-      run_timed_step php-static-analysis "${PHP_BIN}" scripts/php_unused_helpers_guard.php
+      run_timed_step javascript-unused-symbols "${NODE_BIN}" "$(fvplus::path_for_command "${NODE_BIN}" "scripts/js_unused_symbols_guard.mjs")"
+      run_timed_step php-static-analysis "${PHP_BIN}" "$(fvplus::path_for_command "${PHP_BIN}" "scripts/php_unused_helpers_guard.php")"
       ;;
     tests)
       run_timed_step node-mobile-tests "${NODE_BIN}" --test tests/mobile-touch-support.test.mjs tests/mobile-regression-guard.test.mjs

tests/versioning-guard.test.mjs

@@ -367,8 +367,8 @@ test('shared ci suite centralizes linting, tests, guards, docs metadata, and smo
     assert.match(runCiSuite, /NPX_BIN="\$\(fvplus::resolve_platform_command npx\)"/);
     assert.match(runCiSuite, /"\$\{NODE_BIN\}" --check/);
     assert.match(runCiSuite, /"\$\{PHP_BIN\}" -l/);
-    assert.match(runCiSuite, /"\$\{NODE_BIN\}" scripts\/js_unused_symbols_guard\.mjs/);
-    assert.match(runCiSuite, /"\$\{PHP_BIN\}" scripts\/php_unused_helpers_guard\.php/);
+    assert.match(runCiSuite, /"\$\{NODE_BIN\}" "\$\(fvplus::path_for_command "\$\{NODE_BIN\}" "scripts\/js_unused_symbols_guard\.mjs"\)"/);
+    assert.match(runCiSuite, /"\$\{PHP_BIN\}" "\$\(fvplus::path_for_command "\$\{PHP_BIN\}" "scripts\/php_unused_helpers_guard\.php"\)"/);
     assert.match(runCiSuite, /"\$\{NODE_BIN\}" --test tests\/mobile-touch-support\.test\.mjs tests\/mobile-regression-guard\.test\.mjs/);
     assert.match(runCiSuite, /"\$\{NODE_BIN\}" --test tests\/\*\.mjs/);
     assert.match(runCiSuite, /"\$\{NODE_BIN\}" --test tests\/versioning-guard\.test\.mjs tests\/support-policy-contract\.test\.mjs/);