Skip to content

Commit 8d53095

Browse files
Fix dev branch validation in back-merge workflow
1 parent f078fe9 commit 8d53095

3 files changed

Lines changed: 5 additions & 0 deletions

File tree

.github/workflows/backmerge-main-to-dev.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ jobs:
3737
3838
- name: Validate merged dev state before push
3939
env:
40+
FVPLUS_EXPECT_PLUGIN_BRANCH: 'dev'
4041
FVPLUS_UNRAID_MATRIX: ${{ secrets.FVPLUS_UNRAID_MATRIX }}
4142
FVPLUS_I18N_STRICT: '1'
4243
FVPLUS_DEAD_CODE_STRICT: '1'

scripts/workflow_self_check.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,9 @@ if (/gh release create/.test(releaseMainWorkflow) || /gh release edit/.test(rele
8282
if (!/upload-artifact@v4/.test(backmergeWorkflow)) {
8383
fail('Back-merge workflow must upload debug artifacts on failure.');
8484
}
85+
if (!/FVPLUS_EXPECT_PLUGIN_BRANCH:\s*'dev'/.test(backmergeWorkflow)) {
86+
fail('Back-merge workflow must validate merged dev state with FVPLUS_EXPECT_PLUGIN_BRANCH set to dev.');
87+
}
8588
8689
for (const workflowPath of [
8790
'.github/workflows/ci.yml',

tests/versioning-guard.test.mjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,7 @@ test('validation workflows delegate to the shared ci suite with dev coverage, fa
350350
}
351351

352352
assert.match(backmergeWorkflow, /Validate merged dev state before push/);
353+
assert.match(backmergeWorkflow, /FVPLUS_EXPECT_PLUGIN_BRANCH:\s*'dev'/);
353354
assert.match(backmergeWorkflow, /bash scripts\/run_ci_suite\.sh/);
354355
assert.match(backmergeWorkflow, /Setup CI environment/);
355356
assert.match(backmergeWorkflow, /uses:\s*\.\/\.github\/actions\/setup-ci-env/);

0 commit comments

Comments
 (0)