Harden split settings runtime globals

Author: alexphillips-dev

archive/folderview.plus-2026.03.22.02.txz

@@ -0,0 +1 @@
+cb38a109c5d22bb98b50877f456e37875448dc583c33f188a5be8975d8be5563  folderview.plus-2026.03.22.02.txz

archive/folderview.plus-2026.03.22.02.txz.sha256

@@ -6,13 +6,17 @@
 <!ENTITY launch "Settings/FolderViewPlus">
 <!ENTITY plugdir "/usr/local/emhttp/plugins/&name;">
 <!ENTITY pluginURL "https://raw.githubusercontent.com/&github;/dev/folderview.plus.plg">
-<!ENTITY version "2026.03.22.01">
-<!ENTITY md5 "8a9c03722bd35bb4d2524d40f4aaf337">
+<!ENTITY version "2026.03.22.02">
+<!ENTITY md5 "17fd49f970141da321242e9f70ea7e07">
 ]>
 
 <PLUGIN name="&name;" author="&author;" version="&version;" launch="&launch;" pluginURL="&pluginURL;" icon="folder-icon.png" support="https://forums.unraid.net/topic/197631-plugin-folderview-plus/" min="7.0.0">
     <CHANGES>
 
+###2026.03.22.02
+- Maintenance: Update tests for split settings runtime.
+
+
 ###2026.03.22.01
 - UX: Refined settings and on-screen update messaging for clarity and consistency.
 - Quality: Strengthened release automation and regression guards to prevent note drift.

folderview.plus.plg

@@ -538,6 +538,47 @@ const exportSupportBundle = () => {
     });
 };
 
+Object.assign(window, {
+    lastDiagnostics,
+    ACTIVITY_FEED_MAX_ENTRIES,
+    getDiagnostics,
+    getSupportBundle,
+    runDiagnosticAction,
+    trackDiagnosticsEvent,
+    fetchPrefs,
+    postPrefs,
+    createBackup,
+    createGlobalRollbackCheckpointApi,
+    restorePreviousGlobalRollbackCheckpointApi,
+    restoreLatest,
+    restoreLatestUndo,
+    executeFolderRuntimeAction,
+    runScheduledBackup,
+    syncDockerOrder,
+    setUpdateStatus,
+    setRollbackStatus,
+    formatActivityTimestamp,
+    renderActivityFeed,
+    addActivityEntry,
+    clearActivityFeed,
+    ADVANCED_MODULE_STATUS_CONFIG,
+    ensureAdvancedModuleStatusHost,
+    renderAdvancedModuleStatus,
+    setAdvancedModuleStatus,
+    claimAdvancedOperationLock,
+    releaseAdvancedOperationLock,
+    withAdvancedOperationLock,
+    renderChangeHistory,
+    refreshChangeHistory,
+    renderDiagnostics,
+    runDiagnostics,
+    repairDiagnostics,
+    exportDiagnosticsByMode,
+    exportDiagnostics,
+    exportSupportBundleByMode,
+    exportSupportBundle
+});
+
 window.FolderViewPlusDiagnostics = Object.freeze({
     getDiagnostics,
     getSupportBundle,

src/folderview.plus/usr/local/emhttp/plugins/folderview.plus/scripts/folderviewplus.activity-diagnostics.js

@@ -844,6 +844,28 @@ const moveFolderUnderDialog = (type, folderId) => {
     openFolderTreeMoveDialog(type, folderId, { modeInsideOnly: true, placement: 'inside' });
 };
 
+Object.assign(window, {
+    buildFolderQuickActionSummary,
+    renderFolderQuickActionSummaryHtml,
+    closeVmRowDetailsDrawer,
+    runVmRowDrawerAction,
+    buildVmRowDetailsDrawerHtml,
+    toggleVmRowDetailsDrawer,
+    showFolderRowQuickActions,
+    openFolderRowQuickActions,
+    clearRowLongPressState,
+    bindRowTouchQuickActions,
+    copyTextToClipboard,
+    copyFolderId,
+    saveFolderRecord,
+    ensureFolderSortModeManual,
+    buildTreeMoveTargetOptions,
+    applyFolderTreeMove,
+    openFolderTreeMoveDialog,
+    moveFolderToRootQuick,
+    moveFolderUnderDialog
+});
+
 window.FolderViewPlusFolderEditor = Object.freeze({
     buildFolderQuickActionSummary,
     renderFolderQuickActionSummaryHtml,

src/folderview.plus/usr/local/emhttp/plugins/folderview.plus/scripts/folderviewplus.folder-editor.js

@@ -14,6 +14,16 @@ const typeFolders = (type) => (type === 'docker' ? dockers : vms);
 const getManagedTypeLabel = (type) => (normalizeManagedType(type) === 'docker' ? 'Docker' : 'VM');
 const getManagedTypePluralLabel = (type) => (normalizeManagedType(type) === 'docker' ? 'Docker' : 'VMs');
 
+Object.assign(window, {
+    tableIdByType,
+    parseJsonResponse,
+    VALID_MANAGED_TYPES,
+    normalizeManagedType,
+    typeFolders,
+    getManagedTypeLabel,
+    getManagedTypePluralLabel
+});
+
 window.FolderViewPlusRuntimeParity = Object.freeze({
     tableIdByType,
     parseJsonResponse,

src/folderview.plus/usr/local/emhttp/plugins/folderview.plus/scripts/folderviewplus.runtime-parity.js

@@ -60,6 +60,23 @@ const ADVANCED_MODULE_KEYS_BY_TAB = Object.freeze({
 });
 const BASIC_WORKSPACE_SECTION_KEYS = new Set(['docker', 'vms']);
 
+Object.assign(window, {
+    ADVANCED_TAB_STORAGE_KEY,
+    ADVANCED_SECTION_STORAGE_KEY,
+    ADVANCED_EXPANDED_STORAGE_KEY,
+    ADVANCED_KNOWN_STORAGE_KEY,
+    SEARCH_ALL_ADVANCED_STORAGE_KEY,
+    LEGACY_ADVANCED_SECTION_KEYS,
+    ADVANCED_SECTION_KEYS,
+    ADVANCED_GROUPS,
+    ADVANCED_GROUP_LABELS,
+    ADVANCED_GROUP_BY_SECTION,
+    ADVANCED_MODULE_STALE_MS,
+    ADVANCED_MODULE_KEYS,
+    ADVANCED_MODULE_KEYS_BY_TAB,
+    BASIC_WORKSPACE_SECTION_KEYS
+});
+
 window.FolderViewPlusSettingsSections = Object.freeze({
     ADVANCED_TAB_STORAGE_KEY,
     ADVANCED_SECTION_STORAGE_KEY,

src/folderview.plus/usr/local/emhttp/plugins/folderview.plus/scripts/folderviewplus.settings-sections.js

@@ -319,6 +319,30 @@ const applyQuickProfilePreset = async (presetId) => {
     });
 };
 
+Object.assign(window, {
+    WIZARD_DONE_STORAGE_KEY,
+    SETUP_ASSISTANT_DONE_STORAGE_KEY,
+    SETUP_ASSISTANT_DRAFT_STORAGE_KEY,
+    SETUP_ASSISTANT_PRESETS_STORAGE_KEY,
+    SETUP_ASSISTANT_DRAFT_MAX_AGE_MS,
+    SETUP_ASSISTANT_PRESETS_MAX,
+    SETUP_ASSISTANT_VERSION,
+    QUICK_PRESET_ACTIVE_STORAGE_KEY,
+    SETUP_ASSISTANT_STEPS,
+    SETUP_ASSISTANT_STEPS_BY_ROUTE,
+    SETUP_ASSISTANT_EXPERIENCE_MODES,
+    SETUP_ASSISTANT_APPLY_SAFETY_MODES,
+    SETUP_ASSISTANT_ENV_PRESETS,
+    SETUP_ASSISTANT_PROFILE_PRESETS,
+    QUICK_PROFILE_PRESETS,
+    normalizeQuickProfilePresetId,
+    getActiveQuickPresetUi,
+    setActiveQuickPresetUi,
+    renderQuickProfilePresetButtons,
+    applyQuickProfileOverrides,
+    applyQuickProfilePreset
+});
+
 window.FolderViewPlusSetupAssistantSupport = Object.freeze({
     WIZARD_DONE_STORAGE_KEY,
     SETUP_ASSISTANT_DONE_STORAGE_KEY,

src/folderview.plus/usr/local/emhttp/plugins/folderview.plus/scripts/folderviewplus.setup-assistant.js

@@ -886,6 +886,24 @@ const quickCreateStarterTemplates = async (type) => {
     }
 };
 
+Object.assign(window, {
+    DEFAULT_STARTER_FOLDER_ICON,
+    STARTER_TEMPLATE_CATEGORY_META,
+    normalizeStarterTemplateCategory,
+    STARTER_TEMPLATE_BLUEPRINTS,
+    STARTER_TEMPLATE_SMART_THRESHOLD,
+    STARTER_TEMPLATE_FALLBACK_BY_TYPE,
+    STARTER_TEMPLATE_MATCH_ALIASES,
+    normalizeStarterTemplateMatchText,
+    buildStarterTemplateHeuristicMap,
+    collectStarterTemplateSmartSignals,
+    resolveStarterTemplateSmartIndexes,
+    buildStarterFolderPayload,
+    promptStarterTemplateSelection,
+    quickCreateStarterFolder,
+    quickCreateStarterTemplates
+});
+
 window.FolderViewPlusStarterTemplates = Object.freeze({
     DEFAULT_STARTER_FOLDER_ICON,
     STARTER_TEMPLATE_CATEGORY_META,

src/folderview.plus/usr/local/emhttp/plugins/folderview.plus/scripts/folderviewplus.starter-templates.js

@@ -5,8 +5,12 @@ import path from 'node:path';
 
 const repoRoot = path.resolve(process.cwd());
 const settingsScriptPaths = [
+    'src/folderview.plus/usr/local/emhttp/plugins/folderview.plus/scripts/folderviewplus.runtime-parity.js',
     'src/folderview.plus/usr/local/emhttp/plugins/folderview.plus/scripts/folderviewplus.settings-sections.js',
+    'src/folderview.plus/usr/local/emhttp/plugins/folderview.plus/scripts/folderviewplus.setup-assistant.js',
+    'src/folderview.plus/usr/local/emhttp/plugins/folderview.plus/scripts/folderviewplus.starter-templates.js',
     'src/folderview.plus/usr/local/emhttp/plugins/folderview.plus/scripts/folderviewplus.activity-diagnostics.js',
+    'src/folderview.plus/usr/local/emhttp/plugins/folderview.plus/scripts/folderviewplus.folder-editor.js',
     'src/folderview.plus/usr/local/emhttp/plugins/folderview.plus/scripts/folderviewplus.js'
 ].map((relativePath) => path.join(repoRoot, relativePath));
 const script = settingsScriptPaths.map((scriptPath) => fs.readFileSync(scriptPath, 'utf8')).join('\n');
@@ -41,3 +45,12 @@ test('advanced backup and template mutations are lock-guarded', () => {
     assert.match(script, /const bulkTemplateAction = \(type, action\) => \{[\s\S]*withAdvancedOperationLock\(type, 'templates'/);
     assert.match(script, /const assignSelectedItems = async \(type, namesOverride = null\) => \{[\s\S]*claimAdvancedOperationLock\(resolvedType, 'bulk'/);
 });
+
+test('split settings modules publish globals for cross-script browser compatibility', () => {
+    assert.match(script, /Object\.assign\(window,\s*\{[\s\S]*tableIdByType/);
+    assert.match(script, /Object\.assign\(window,\s*\{[\s\S]*ADVANCED_TAB_STORAGE_KEY/);
+    assert.match(script, /Object\.assign\(window,\s*\{[\s\S]*SETUP_ASSISTANT_DONE_STORAGE_KEY/);
+    assert.match(script, /Object\.assign\(window,\s*\{[\s\S]*STARTER_TEMPLATE_BLUEPRINTS/);
+    assert.match(script, /Object\.assign\(window,\s*\{[\s\S]*postPrefs/);
+    assert.match(script, /Object\.assign\(window,\s*\{[\s\S]*openFolderRowQuickActions/);
+});