Add Docker branch folder deletion and clone regression tests

Author: alexphillips-dev

archive/folderview.plus-2026.03.27.14.txz.sha256

@@ -0,0 +1 @@
+2e50919724345599044aadda70d74bab2830c4a6c5bf07ee30ecb26b875e0a55  folderview.plus-2026.03.29.11.txz

archive/folderview.plus-2026.03.27.14.txz archive/folderview.plus-2026.03.29.11.txzarchive/folderview.plus-2026.03.27.14.txz renamed to archive/folderview.plus-2026.03.29.11.txz

@@ -6,13 +6,17 @@
 <!ENTITY launch "Settings/FolderViewPlus">
 <!ENTITY plugdir "/usr/local/emhttp/plugins/&name;">
 <!ENTITY pluginURL "https://raw.githubusercontent.com/&github;/dev/folderview.plus.plg">
-<!ENTITY version "2026.03.29.10">
-<!ENTITY md5 "c444ec2ee928781929076fd070f76b70">
+<!ENTITY version "2026.03.29.11">
+<!ENTITY md5 "3823ae3651dbae4395f304b29c7c149f">
 ]>
 
 <PLUGIN name="&name;" author="&author;" version="&version;" launch="&launch;" pluginURL="&pluginURL;" icon="folder-icon.png" support="https://forums.unraid.net/topic/197631-plugin-folderview-plus/" min="7.0.0">
     <CHANGES>
 
+###2026.03.29.11
+- Feature: Add `Delete branch folders` under Docker branch actions to remove a root folder and every nested child folder in that branch.
+- Quality: Add behavior-level regression coverage for clone-of-clone branch cloning, deep-copy payload safety, rollback ordering, and branch delete ordering.
+
 ###2026.03.29.10
 - Fix: Restore Docker branch hover submenus by allowing runtime context menus to keep submenu overflow visible.
 - Feature: Add a Docker `Clone` submenu with `Clone folder` plus `Clone branch`, including nested branch cloning with preserved parent-child structure.

archive/folderview.plus-2026.03.29.11.txz.sha256

@@ -4512,6 +4512,95 @@ const rmFolder = (id) => {
     });
 };
 
+const getLockedDockerBranchFolderIds = (id) => {
+    const branchIds = [id, ...getFolderDescendants(id)];
+    return branchIds.filter((folderId) => isDockerFolderLocked(folderId));
+};
+
+const ensureDockerBranchUnlocked = (id, actionLabel = 'This action') => {
+    const lockedIds = getLockedDockerBranchFolderIds(id);
+    if (!lockedIds.length) {
+        return true;
+    }
+    const previewNames = lockedIds
+        .slice(0, 4)
+        .map((folderId) => escapeHtml(String(globalFolders?.[folderId]?.name || folderId)))
+        .join(', ');
+    const hiddenCount = Math.max(0, lockedIds.length - Math.min(4, lockedIds.length));
+    const lockedLabel = lockedIds.length === 1 ? 'A folder in this branch is locked.' : `${lockedIds.length} folders in this branch are locked.`;
+    const hiddenSuffix = hiddenCount > 0 ? ` (+${hiddenCount} more)` : '';
+    const detailsLine = previewNames ? `<br><strong>Locked:</strong> ${previewNames}${hiddenSuffix}` : '';
+    swal({
+        title: 'Folder branch locked',
+        text: `${escapeHtml(actionLabel)} is blocked while ${lockedLabel}${detailsLine}<br>Unlock the locked folder rows first and try again.`,
+        type: 'info',
+        html: true,
+        confirmButtonText: 'OK'
+    });
+    return false;
+};
+
+const deleteDockerFolderBranch = async (id) => {
+    const deleteIds = [...getFolderDescendants(id)].reverse();
+    deleteIds.push(id);
+    for (const deleteId of deleteIds) {
+        await $.post('/plugins/folderview.plus/server/delete.php', { type: 'docker', id: deleteId }).promise();
+    }
+};
+
+const rmFolderBranch = (id) => {
+    if (FOLDER_VIEW_DEBUG_MODE) console.log(`[FV3_DEBUG] rmFolderBranch (id: ${id}): Entry.`);
+    if (!ensureDockerBranchUnlocked(id, 'Delete branch folders')) {
+        return;
+    }
+    const folder = globalFolders[id] || {};
+    const folderName = escapeHtml(String(folder.name || id));
+    const descendantIds = getFolderDescendants(id);
+    const branchIds = [id, ...descendantIds];
+    const previewNames = branchIds
+        .slice(0, 5)
+        .map((folderId) => escapeHtml(String(globalFolders?.[folderId]?.name || folderId)))
+        .join(', ');
+    const hiddenCount = Math.max(0, branchIds.length - Math.min(5, branchIds.length));
+    const impactLines = [
+        `Delete branch folders: ${folderName}`,
+        `This will permanently delete <strong>${branchIds.length}</strong> folder${branchIds.length === 1 ? '' : 's'} in this branch.`,
+        `Nested child folders will be deleted with the root folder and will <strong>not</strong> be re-parented.`
+    ];
+    if (previewNames) {
+        impactLines.push(`<strong>Branch:</strong> ${previewNames}${hiddenCount > 0 ? ` (+${hiddenCount} more)` : ''}`);
+    }
+    swal({
+        title: $.i18n('are-you-sure'),
+        text: impactLines.join('<br>'),
+        type: 'warning',
+        html: true,
+        showCancelButton: true,
+        confirmButtonText: $.i18n('yes-delete'),
+        cancelButtonText: $.i18n('cancel'),
+        showLoaderOnConfirm: true
+    },
+    async (confirmed) => {
+        if (FOLDER_VIEW_DEBUG_MODE) console.log(`[FV3_DEBUG] rmFolderBranch (id: ${id}): Swal callback. Confirmed: ${confirmed}`);
+        if (!confirmed) { setTimeout(loadlist, 0); return; }
+        $('div.spinner.fixed').show('slow');
+        try {
+            const result = await runDockerGuardedAction('delete-folder-branch', async () => {
+                await deleteDockerFolderBranch(id);
+                setTimeout(loadlist, 500);
+            }, {
+                userMessage: getDockerMenuLabel('delete-branch-folders-failed', 'Failed to delete branch folders.'),
+                userVisible: true
+            });
+            if (!result.ok) {
+                setTimeout(loadlist, 0);
+            }
+        } finally {
+            $('div.spinner.fixed').hide('slow');
+        }
+    });
+};
+
 /**
  * Redirect to the page to edit the folder
  * @param {string} id the id of the folder
@@ -5483,6 +5572,14 @@ const addDockerFolderContext = (id) => {
                 }
             });
         }
+        branchSubMenu.push({
+            text: 'Delete branch folders',
+            icon: 'fa-trash',
+            action: (evt) => {
+                evt.preventDefault();
+                rmFolderBranch(id);
+            }
+        });
         if (branchSubMenu.length > 0) {
             opts.push({
                 text: 'Branch actions',