fix: make diagnostics export download reliably

Author: alexphillips-dev

archive/folderview.plus-2026.03.06.4.txz

@@ -6,13 +6,17 @@
 <!ENTITY launch "Settings/FolderViewPlus">
 <!ENTITY plugdir "/usr/local/emhttp/plugins/&name;">
 <!ENTITY pluginURL "https://raw.githubusercontent.com/&github;/main/folderview.plus.plg">
-<!ENTITY version "2026.03.06.3">
-<!ENTITY md5 "39ac8cf761703bbef75674f8105c8814">
+<!ENTITY version "2026.03.06.4">
+<!ENTITY md5 "e906454fc17b52f18e9f9e1530c1377b">
 ]>
 
 <PLUGIN name="&name;" author="&author;" version="&version;" launch="&launch;" pluginURL="&pluginURL;" icon="folder-open-o" support="https://github.com/alexphillips-dev/FolderView-Plus/issues" min="7.0.0">
     <CHANGES>
 
+###2026.03.06.4
+- Fix diagnostics export reliability by restoring direct-download behavior.
+- Export now defaults to sanitized diagnostics immediately and falls back to cached/latest data if live diagnostics refresh fails.
+
 ###2026.03.06.3
 - Expand diagnostics export to schema v2 with richer bug-fixing data:
   - `integrityChecks` per type (duplicate names/assignments, orphaned members, invalid regex/rules, manual-order gaps),

folderview.plus.plg

@@ -1236,29 +1236,39 @@ const repairDiagnostics = async (action) => {
     }
 };
 
-const exportDiagnostics = async () => {
-    swal({
-        title: 'Export diagnostics',
-        text: 'Include full details (paths, names, and request metadata)?\nChoose Cancel for sanitized export.',
-        type: 'warning',
-        showCancelButton: true,
-        confirmButtonText: 'Full export',
-        cancelButtonText: 'Sanitized export'
-    }, async (useFull) => {
-        const privacy = useFull ? 'full' : 'sanitized';
+const exportDiagnostics = async (privacy = 'sanitized') => {
+    const mode = privacy === 'full' ? 'full' : 'sanitized';
+    let diagnostics = null;
+
+    const cachedMode = (lastDiagnostics?.privacyMode || 'sanitized');
+    if (lastDiagnostics && cachedMode === mode) {
+        diagnostics = lastDiagnostics;
+    }
+
+    if (!diagnostics) {
         try {
-            const diagnostics = await getDiagnostics(privacy);
+            diagnostics = await getDiagnostics(mode);
             renderDiagnostics(diagnostics);
-            downloadFile('FolderView Plus Diagnostics.json', toPrettyJson(diagnostics || {}));
-            await trackDiagnosticsEvent({
-                eventType: 'diagnostics_export',
-                details: {
-                    privacyMode: privacy,
-                    schemaVersion: diagnostics?.schemaVersion || null
-                }
-            });
         } catch (error) {
-            showError('Diagnostics export failed', error);
+            if (lastDiagnostics) {
+                diagnostics = lastDiagnostics;
+            } else {
+                diagnostics = {
+                    schemaVersion: 2,
+                    privacyMode: mode,
+                    checkedAt: new Date().toISOString(),
+                    error: error?.message || String(error)
+                };
+            }
+        }
+    }
+
+    downloadFile('FolderView Plus Diagnostics.json', toPrettyJson(diagnostics || {}));
+    trackDiagnosticsEvent({
+        eventType: 'diagnostics_export',
+        details: {
+            privacyMode: mode,
+            schemaVersion: diagnostics?.schemaVersion || null
         }
     });
 };