Fix shellcheck source resolution for shared script library

Author: alexphillips-dev

.github/workflows/ci.yml

@@ -31,7 +31,7 @@ jobs:
           set -euo pipefail
           mapfile -d '' files < <(find . -type f \( -name "*.sh" -o -path "./.githooks/pre-push" \) -print0)
           for f in "${files[@]}"; do
-            shellcheck "$f"
+            shellcheck -x --source-path=SCRIPTDIR "$f"
           done
 
       - name: Lint JavaScript syntax

scripts/doctor.sh

@@ -2,7 +2,7 @@
 set -euo pipefail
 
 ROOT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
-# shellcheck source=./lib.sh
+# shellcheck source=scripts/lib.sh
 source "${ROOT_DIR}/scripts/lib.sh"
 
 REQUIRED_COMMANDS=(
@@ -31,4 +31,3 @@ for cmd in "${REQUIRED_COMMANDS[@]}"; do
     echo "  ${cmd}: installed"
   fi
 done
-

scripts/ensure_plg_changes_entry.sh

@@ -3,7 +3,7 @@ set -euo pipefail
 
 ROOT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
 PLG_FILE="${ROOT_DIR}/folderview.plus.plg"
-# shellcheck source=./lib.sh
+# shellcheck source=scripts/lib.sh
 source "${ROOT_DIR}/scripts/lib.sh"
 
 if [[ ! -f "${PLG_FILE}" ]]; then

scripts/install_smoke.sh

@@ -4,7 +4,7 @@ set -euo pipefail
 ROOT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
 PLG_FILE="${ROOT_DIR}/folderview.plus.plg"
 ARCHIVE_DIR="${FVPLUS_ARCHIVE_DIR:-${ROOT_DIR}/archive}"
-# shellcheck source=./lib.sh
+# shellcheck source=scripts/lib.sh
 source "${ROOT_DIR}/scripts/lib.sh"
 
 if [[ ! -f "${PLG_FILE}" ]]; then

scripts/release_prepare.sh

@@ -2,7 +2,7 @@
 set -euo pipefail
 
 ROOT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
-# shellcheck source=./lib.sh
+# shellcheck source=scripts/lib.sh
 source "${ROOT_DIR}/scripts/lib.sh"
 cd "${ROOT_DIR}"
 

tests/versioning-guard.test.mjs

@@ -185,7 +185,7 @@ test('release workflows keep checksum assets and metadata changes', () => {
 test('CI includes shellcheck linting for repository shell scripts', () => {
     assert.match(ciWorkflow, /Install shellcheck/);
     assert.match(ciWorkflow, /Lint shell scripts/);
-    assert.match(ciWorkflow, /shellcheck "\$f"/);
+    assert.match(ciWorkflow, /shellcheck -x --source-path=SCRIPTDIR "\$f"/);
 });
 
 test('shared script library and doctor preflight exist with required helpers', () => {