Skip release publishing for workflow-only main pushes

(cherry picked from commit f0dd557)

Author: alexphillips-dev

.github/workflows/release-on-main.yml

@@ -26,8 +26,48 @@ jobs:
       - name: Setup CI environment
         uses: ./.github/actions/setup-ci-env
 
+      - name: Detect release artifact changes
+        id: release_scope
+        shell: bash
+        run: |
+          set -euo pipefail
+          BEFORE_SHA='${{ github.event.before }}'
+          AFTER_SHA='${{ github.sha }}'
+          RANGE="${BEFORE_SHA}..${AFTER_SHA}"
+          if [[ -z "${BEFORE_SHA}" || "${BEFORE_SHA}" =~ ^0+$ ]]; then
+            RANGE="${AFTER_SHA}^..${AFTER_SHA}"
+          fi
+
+          mapfile -t changed_files < <(git diff --name-only "${RANGE}" || true)
+          should_publish=0
+          for changed_file in "${changed_files[@]}"; do
+            case "${changed_file}" in
+              folderview.plus.plg|folderview.plus.xml|archive/*.txz|archive/*.sha256)
+                should_publish=1
+                break
+                ;;
+            esac
+          done
+
+          {
+            echo "range=${RANGE}"
+            echo "should_publish=${should_publish}"
+          } >> "${GITHUB_OUTPUT}"
+
+      - name: Skip release publish for non-release main pushes
+        if: steps.release_scope.outputs.should_publish != '1'
+        shell: bash
+        run: |
+          {
+            echo "## Release publish skipped"
+            echo
+            echo "No release artifacts changed on this \`main\` push, so GitHub release publishing was intentionally skipped."
+            echo "Workflow/process-only syncs can land on \`main\` without creating a new plugin release."
+          } >> "${GITHUB_STEP_SUMMARY}"
+
       - name: Resolve release version and archive
         id: release_meta
+        if: steps.release_scope.outputs.should_publish == '1'
         run: |
           set -euo pipefail
           VERSION=$(grep -oP '<!ENTITY version "\K[^"]+' folderview.plus.plg)
@@ -48,6 +88,7 @@ jobs:
           echo "tag=v${VERSION}" >> "$GITHUB_OUTPUT"
 
       - name: Run release validation suite
+        if: steps.release_scope.outputs.should_publish == '1'
         env:
           FVPLUS_UNRAID_MATRIX: ${{ secrets.FVPLUS_UNRAID_MATRIX }}
           FVPLUS_UNRAID_MATRIX_REQUIRED: ${{ secrets.FVPLUS_UNRAID_MATRIX != '' && '1' || '0' }}
@@ -80,13 +121,15 @@ jobs:
 
       - name: Build release notes from current CHANGES block
         id: notes
+        if: steps.release_scope.outputs.should_publish == '1'
         run: |
           set -euo pipefail
           VERSION="${{ steps.release_meta.outputs.version }}"
           chmod +x scripts/build_release_notes.sh
           bash scripts/build_release_notes.sh --version "${VERSION}" --output release_notes.md
 
       - name: Validate remote raw publish artifacts
+        if: steps.release_scope.outputs.should_publish == '1'
         env:
           FVPLUS_REMOTE_PUBLISH_ATTEMPTS: '30'
           FVPLUS_REMOTE_PUBLISH_DELAY_SEC: '10'
@@ -95,6 +138,7 @@ jobs:
           bash scripts/remote_publish_guard.sh
 
       - name: Ensure GitHub CLI
+        if: steps.release_scope.outputs.should_publish == '1'
         run: |
           if command -v gh >/dev/null 2>&1; then
             gh --version
@@ -104,6 +148,7 @@ jobs:
           sudo apt-get install -y gh
 
       - name: Create or update GitHub release
+        if: steps.release_scope.outputs.should_publish == '1'
         env:
           GH_TOKEN: ${{ github.token }}
         run: |

scripts/workflow_self_check.sh

@@ -67,6 +67,12 @@ if (!/ci-duration-report/.test(ciWorkflow)) {
 if (!/bash scripts\/build_release_notes\.sh/.test(releaseOnMainWorkflow)) {
   fail('Release On Main workflow must build release notes via scripts/build_release_notes.sh.');
 }
+if (!/Detect release artifact changes/.test(releaseOnMainWorkflow)) {
+  fail('Release On Main workflow must detect whether a main push actually changed release artifacts.');
+}
+if (!/Skip release publish for non-release main pushes/.test(releaseOnMainWorkflow)) {
+  fail('Release On Main workflow must explicitly skip publishing for workflow-only main pushes.');
+}
 if (!/gh release create/.test(releaseOnMainWorkflow) || !/gh release edit/.test(releaseOnMainWorkflow)) {
   fail('Release On Main workflow must own GitHub release publishing.');
 }

tests/versioning-guard.test.mjs

@@ -364,6 +364,9 @@ test('validation workflows delegate to the shared ci suite with dev coverage, fa
 });
 
 test('release-on-main validates remote raw publish artifacts before publishing releases', () => {
+    assert.match(releaseOnMainWorkflow, /Detect release artifact changes/);
+    assert.match(releaseOnMainWorkflow, /should_publish/);
+    assert.match(releaseOnMainWorkflow, /Skip release publish for non-release main pushes/);
     assert.match(releaseOnMainWorkflow, /Validate remote raw publish artifacts/);
     assert.match(releaseOnMainWorkflow, /FVPLUS_REMOTE_PUBLISH_ATTEMPTS:\s*'30'/);
     assert.match(releaseOnMainWorkflow, /FVPLUS_REMOTE_PUBLISH_DELAY_SEC:\s*'10'/);