Safer content-type checking (fixed create dir)

Author: Anthony Nowell

examples/dir-make-del.js

@@ -0,0 +1,28 @@
+/*
+	dir-list.js
+
+	Example shows how to iterate over contents of a directory using Algorithmia's DataAPI.
+
+*/
+
+var algorithmia = require("../lib/algorithmia.js");
+var client = algorithmia.client(process.env.ALGORITHMIA_API_KEY);
+
+console.log("Creating directory...");
+var testDir = client.dir("data://.my/node_client_test");
+testDir.create(function(err) {
+    if(err) {
+        console.log("Error: " + JSON.stringify(err));
+    } else {
+        console.log("Create directory succeeded. Deleting directory...");
+    }
+
+    console.log("Deleting directory...");
+    testDir.delete(function(err) {
+        if(err) {
+            return console.log("Error: " + JSON.stringify(err));
+        }
+        console.log("Delete directory succeeded.");
+    });
+});
+

lib/algorithmia.js

@@ -69,14 +69,16 @@ AlgorithmiaClient = (function() {
       });
       res.on('end', function() {
         var body, buff, ct;
-        ct = res.headers['content-type'] || accept;
-        if (ct.startsWith('application/json')) {
-          buff = chunks.join('');
-          body = buff === '' ? {} : JSON.parse(buff);
-        } else if (ct.startsWith('text/plain')) {
-          body = chunks.join('');
-        } else {
-          body = Buffer.concat(chunks);
+        ct = res.headers['content-type'];
+        if (typeof ct === 'string') {
+          if (ct.startsWith('application/json')) {
+            buff = chunks.join('');
+            body = buff === '' ? {} : JSON.parse(buff);
+          } else if (ct.startsWith('text/plain')) {
+            body = chunks.join('');
+          } else {
+            body = Buffer.concat(chunks);
+          }
         }
         if (callback) {
           if (res.statusCode < 200 || res.statusCode >= 300) {

src/algorithmia.coffee

@@ -66,14 +66,15 @@ class AlgorithmiaClient
         chunks.push chunk
 
       res.on 'end', ->
-        ct = res.headers['content-type'] || accept
-        if ct.startsWith('application/json')
-          buff = chunks.join('')
-          body = if buff == '' then {} else JSON.parse(buff)
-        else if ct.startsWith('text/plain')
-          body = chunks.join('')
-        else
-          body = Buffer.concat(chunks)
+        ct = res.headers['content-type']
+        if typeof ct == 'string'
+          if ct.startsWith('application/json')
+            buff = chunks.join('')
+            body = if buff == '' then {} else JSON.parse(buff)
+          else if ct.startsWith('text/plain')
+            body = chunks.join('')
+          else
+            body = Buffer.concat(chunks)
 
         if callback
           if res.statusCode < 200 || res.statusCode >= 300