fix: copy NacosDiscoveryProperties to avoid sharing mutable state (#4303)

Author: xuxiaowei-com-cn

spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/main/java/com/alibaba/cloud/nacos/NacosDiscoveryProperties.java

@@ -326,7 +326,50 @@ else if (IPV6.equalsIgnoreCase(ipType)) {
 			applicationEventPublisher
 					.publishEvent(new NacosDiscoveryInfoChangedEvent(this));
 		}
-		nacosServiceManager.setNacosDiscoveryProperties(this);
+		nacosServiceManager.setNacosDiscoveryProperties(copyNacosDiscoveryProperties());
+	}
+
+	/**
+	 * copy {@link NacosDiscoveryProperties} .
+	 * @return NacosDiscoveryProperties
+	 */
+	private NacosDiscoveryProperties copyNacosDiscoveryProperties() {
+		NacosDiscoveryProperties nacosDiscoveryProperties = new NacosDiscoveryProperties();
+		nacosDiscoveryProperties.endpoint = this.endpoint;
+		nacosDiscoveryProperties.namespace = this.namespace;
+		nacosDiscoveryProperties.logName = this.logName;
+		nacosDiscoveryProperties.weight = this.weight;
+		nacosDiscoveryProperties.clusterName = this.clusterName;
+		nacosDiscoveryProperties.service = this.service;
+		nacosDiscoveryProperties.registerEnabled = this.registerEnabled;
+		nacosDiscoveryProperties.ip = this.ip;
+		nacosDiscoveryProperties.ipType = this.ipType;
+		nacosDiscoveryProperties.networkInterface = this.networkInterface;
+		nacosDiscoveryProperties.port = this.port;
+		nacosDiscoveryProperties.secure = this.secure;
+		nacosDiscoveryProperties.metadata = new HashMap<>(this.metadata);
+		nacosDiscoveryProperties.serverAddr = this.serverAddr;
+		nacosDiscoveryProperties.accessKey = this.accessKey;
+		nacosDiscoveryProperties.secretKey = this.secretKey;
+		nacosDiscoveryProperties.heartBeatInterval = this.heartBeatInterval;
+		nacosDiscoveryProperties.heartBeatTimeout = this.heartBeatTimeout;
+		nacosDiscoveryProperties.ipDeleteTimeout = this.ipDeleteTimeout;
+		nacosDiscoveryProperties.namingLoadCacheAtStart = this.namingLoadCacheAtStart;
+		nacosDiscoveryProperties.watchDelay = this.watchDelay;
+		nacosDiscoveryProperties.group = this.group;
+		nacosDiscoveryProperties.username = this.username;
+		nacosDiscoveryProperties.password = this.password;
+		nacosDiscoveryProperties.instanceEnabled = this.instanceEnabled;
+		nacosDiscoveryProperties.ephemeral = this.ephemeral;
+		nacosDiscoveryProperties.failureToleranceEnabled = this.failureToleranceEnabled;
+		nacosDiscoveryProperties.failFast = this.failFast;
+		nacosDiscoveryProperties.gracefulShutdownWaitTime = this.gracefulShutdownWaitTime;
+		nacosDiscoveryProperties.inetIPv6Utils = this.inetIPv6Utils;
+		nacosDiscoveryProperties.inetUtils = this.inetUtils;
+		nacosDiscoveryProperties.environment = this.environment;
+		nacosDiscoveryProperties.nacosServiceManager = this.nacosServiceManager;
+		nacosDiscoveryProperties.applicationEventPublisher = this.applicationEventPublisher;
+		return nacosDiscoveryProperties;
 	}
 
 	/**

spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-nacos-discovery/src/test/java/com/alibaba/cloud/nacos/NacosDiscoveryPropertiesTests.java

@@ -0,0 +1,107 @@
+/*
+ * Copyright 2026-2026 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.alibaba.cloud.nacos;
+
+import java.util.UUID;
+
+import com.alibaba.cloud.nacos.discovery.NacosDiscoveryClientConfiguration;
+import com.alibaba.cloud.nacos.event.NacosDiscoveryInfoChangedEvent;
+import com.alibaba.cloud.nacos.registry.NacosServiceRegistryAutoConfiguration;
+import org.junit.jupiter.api.Test;
+
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
+import org.springframework.boot.autoconfigure.ImportAutoConfiguration;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.cloud.client.discovery.EnableDiscoveryClient;
+import org.springframework.cloud.client.serviceregistry.AutoServiceRegistrationConfiguration;
+import org.springframework.context.annotation.Configuration;
+import org.springframework.context.event.EventListener;
+
+import static com.alibaba.cloud.nacos.NacosDiscoveryPropertiesTests.TestConfig;
+import static org.assertj.core.api.Assertions.assertThat;
+
+/**
+ * @author xuxiaowei
+ */
+@EnableDiscoveryClient(autoRegister = false)
+@SpringBootTest(classes = TestConfig.class,
+		properties = {
+		"spring.application.name=app",
+		"spring.cloud.nacos.discovery.server-addr=321.321.321.321:8848",
+		"spring.cloud.nacos.server-addr=123.123.123.123:8848" })
+class NacosDiscoveryPropertiesTests {
+
+	private static final String KEY = UUID.randomUUID().toString();
+
+	@Autowired
+	private NacosDiscoveryProperties properties;
+
+	@Test
+	public void testGetServerAddr() {
+		assertThat(properties.getServerAddr()).isEqualTo("321.321.321.321:8848");
+	}
+
+	@Test
+	public void testNacosDiscoveryInfoChangedEvent() throws Exception {
+		TestConfig.eventPublished = false;
+		// modify some property
+		String password = UUID.randomUUID().toString();
+		String value = UUID.randomUUID().toString();
+		properties.setPassword(password);
+		properties.getMetadata().put(KEY, value);
+		// trigger init
+		properties.init();
+		// check if event is published
+		assertThat(TestConfig.eventPublished).isTrue();
+		assertThat(TestConfig.password).isEqualTo(password);
+		assertThat(TestConfig.metadataValue).isEqualTo(value);
+	}
+
+	@Configuration
+	@EnableAutoConfiguration
+	@ImportAutoConfiguration({ AutoServiceRegistrationConfiguration.class,
+			NacosDiscoveryClientConfiguration.class,
+			NacosServiceRegistryAutoConfiguration.class })
+	public static class TestConfig {
+
+		/**
+		 * eventPublished.
+		 */
+		public static boolean eventPublished = false;
+
+		/**
+		 * password.
+		 */
+		public static String password;
+
+		/**
+		 * metadataValue.
+		 */
+		public static String metadataValue;
+
+		@EventListener
+		public void onEvent(NacosDiscoveryInfoChangedEvent event) {
+			eventPublished = true;
+			password = event.getSource().getPassword();
+			metadataValue = event.getSource().getMetadata().get(KEY);
+		}
+
+	}
+
+}
+