[Code Health] Remove Abseil usages

This patch removes the remaining Abseil usages outside
of the protobuf messaging dependencies.

Some C++20 modernizations are included, espeically in the CDDL
code.

Bug: 158433927
Change-Id: Ibcb865e6ae712f905e8453df8e9a30f7a5291dca
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7585316
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>

Author: baylesj

.github/workflows/main.yml

@@ -0,0 +1,58 @@
+name: Exact OpenScreen Mirror with .github Protection
+
+on:
+  workflow_dispatch:  # Manuel olarak tetiklenebilir
+  schedule:
+    - cron: '0 0 */3 * *'  # Her 3 günde bir otomatik olarak çalışır
+
+jobs:
+  mirror:
+    runs-on: ubuntu-latest  # İş akışı Ubuntu üzerinde çalışır
+    steps:
+      # Adım 1: Mevcut depoyu tam tarihçe ile al
+      - name: Checkout Full History
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0  # Tüm commit geçmişini al
+
+      # Adım 2: OpenScreen verilerini mevcut depoya entegre et
+      - name: Integrate OpenScreen
+        run: |
+          # 'actions' branch'ine geç
+          git checkout actions
+          
+          # OpenScreen'i uzak depo olarak ekle
+          git remote add openscreen https://chromium.googlesource.com/openscreen
+          
+          # OpenScreen'den tüm branch'leri ve tag'leri al
+          git fetch openscreen --tags
+          
+          # OpenScreen'deki tüm branch'leri yerel olarak oluştur (main hariç)
+          git branch -r | grep 'openscreen/' | grep -v 'HEAD' | while read remote; do
+            branch_name=${remote#openscreen/}
+            git branch -f "$branch_name" "$remote"
+          done
+
+      # Adım 3: Main branch'i koru ve .github dosyalarını güncelle
+      - name: Protect Main Branch
+        run: |
+          # Main branch'e geç
+          git checkout main
+          
+          # Git kullanıcı bilgilerini ayarla (commit için)
+          git config user.name "GitHub Actions"
+          git config user.email "actions@github.com"
+          
+          # 'actions' branch'inden .github klasörünü al ve main branch'ine merge et
+          git checkout actions -- .github
+          git add .github
+          git commit --amend --no-edit  # Commit'i güncelle (fast-forward olmadan)
+
+      # Adım 4: Tüm branch'leri ve tag'leri force push et
+      - name: Force Push Mirrored Branches
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}  # GitHub token'ı kullan
+        run: |           
+          # Tüm branch'leri ve tag'leri force push et
+          git push origin --all --force
+          git push origin --tags --force

BUILD.gn

@@ -85,7 +85,6 @@ openscreen_source_set("openscreen_unittests_all") {
     "cast/streaming:unittests",
     "cast/test:unittests",
     "platform:unittests",
-    "third_party/abseil",
     "util:unittests",
   ]
 

DEPS

@@ -459,14 +459,9 @@ include_rules = [
   '+discovery/mdns/public',
   '+discovery/public',
 
-  # Don't include abseil from the root so the path can change via include_dirs
-  # rules when in Chromium.
+  # Don't include Abseil.
   '-third_party/abseil',
-
-  # Abseil allowed headers.
-  # IMPORTANT: Do not add new entries; abseil is being removed from the library.
-  # See https://issuetracker.google.com/158433927
-  '+absl/types/variant.h',
+  '-absl',
 
   # Similar to abseil, don't include boringssl using root path.  Instead,
   # explicitly allow 'openssl' where needed.

build_overrides/build.gni

@@ -17,12 +17,6 @@ build_with_chromium = false
 # `use_custom_libcxx = true`.
 enable_safe_libcxx = true
 
-declare_args() {
-  # Allows googletest to pretty-print various absl types.  Disabled for nacl due
-  # to lack of toolchain support.
-  gtest_enable_absl_printers = true
-}
-
 if (host_os == "mac" || is_apple) {
   # Needed for is_apple when targeting macOS or iOS, independent of host.
   # Needed for host_os=="mac" for running host tool such as gperf in blink

cast/common/BUILD.gn

@@ -38,7 +38,6 @@ openscreen_source_set("certificate") {
 
   deps = [
     "../../platform",
-    "../../third_party/abseil",
     "../../util",
     "certificate/proto:certificate_proto",
   ]
@@ -76,7 +75,6 @@ openscreen_source_set("certificate_boringssl") {
 
   deps = [
     ":certificate",
-    "../../third_party/abseil",
     "../../util",
   ]
 }
@@ -111,7 +109,6 @@ openscreen_source_set("channel") {
   public_deps = [
     ":public",
     "../../platform",
-    "../../third_party/abseil",
     "../../util",
     "channel/proto:channel_proto",
   ]
@@ -141,7 +138,6 @@ openscreen_source_set("public") {
   public_deps = [
     "../../discovery:public",
     "../../platform",
-    "../../third_party/abseil",
     "../../util",
   ]
 }
@@ -187,7 +183,6 @@ openscreen_source_set("test_helpers") {
     "../../discovery:public",
     "../../platform:test",
     "../../testing/util",
-    "../../third_party/abseil",
     "../../third_party/boringssl",
     "../../third_party/googletest:gmock",
     "../../third_party/googletest:gtest",

cast/protocol/BUILD.gn

@@ -74,7 +74,6 @@ openscreen_source_set("unittests") {
     ":receiver_examples",
     ":streaming_examples",
     "../../platform:base",
-    "../../third_party/abseil",
     "../../third_party/googletest:gmock",
     "../../third_party/googletest:gtest",
     "../../util",

cast/receiver/BUILD.gn

@@ -25,7 +25,6 @@ openscreen_source_set("channel") {
 
   public_deps = [
     "../../platform",
-    "../../third_party/abseil",
     "../../third_party/boringssl",
     "../common:channel",
     "../common/channel/proto:channel_proto",

cast/sender/BUILD.gn

@@ -21,7 +21,6 @@ openscreen_source_set("channel") {
   ]
 
   deps = [
-    "../../third_party/abseil",
     "../common:channel",
     "../common/certificate/proto:certificate_proto",
     "../common/channel/proto:channel_proto",
@@ -58,7 +57,6 @@ openscreen_source_set("sender") {
   public_deps = [
     ":channel",
     "../../platform",
-    "../../third_party/abseil",
     "../../util",
     "../common:channel",
     "../common:public",

cast/standalone_sender/streaming_av1_encoder.h

@@ -138,20 +138,20 @@ class StreamingAv1Encoder : public StreamingVideoEncoder {
   std::mutex mutex_;
 
   // Used by the encode thread to sleep until more work is available.
-  std::condition_variable cv_;  // ABSL_GUARDED_BY(mutex_)
+  // TODO(crbug.com/322734860): implement OSP_GUARDED_BY / better mutex support.
+  std::condition_variable cv_;
 
   // These encode parameters not passed in the WorkUnit struct because it is
   // desirable for them to be applied as soon as possible, with the very next
   // WorkUnit popped from the `encode_queue_` on the encode thread, and not to
   // wait until some later WorkUnit is processed.
-  bool needs_key_frame_ /* ABSL_GUARDED_BY(mutex_) */ = true;
-  int target_bitrate_ /* ABSL_GUARDED_BY(mutex_) */ =
-      2 << 20;  // Default: 2 Mbps.
+  bool needs_key_frame_ = true;
+  int target_bitrate_ = 2 << 20;  // Default: 2 Mbps.
 
   // The queue of frame encodes. The size of this queue is implicitly bounded by
   // EncodeAndSend(), where it checks for the total in-flight media duration and
   // maybe drops a frame.
-  std::queue<WorkUnit> encode_queue_;  // ABSL_GUARDED_BY(mutex_)
+  std::queue<WorkUnit> encode_queue_;
 
   // Current AV1 encoder configuration. Most of the fields are unchanging, and
   // are populated in the ctor; but thereafter, only the encode thread accesses

cast/standalone_sender/streaming_vpx_encoder.h

@@ -138,20 +138,20 @@ class StreamingVpxEncoder : public StreamingVideoEncoder {
   std::mutex mutex_;
 
   // Used by the encode thread to sleep until more work is available.
-  std::condition_variable cv_;  // ABSL_GUARDED_BY(mutex_)
+  // TODO(crbug.com/322734860): implement OSP_GUARDED_BY / better mutex support.
+  std::condition_variable cv_;
 
   // These encode parameters not passed in the WorkUnit struct because it is
   // desirable for them to be applied as soon as possible, with the very next
   // WorkUnit popped from the `encode_queue_` on the encode thread, and not to
   // wait until some later WorkUnit is processed.
-  bool needs_key_frame_ /* ABSL_GUARDED_BY(mutex_) */ = true;
-  int target_bitrate_ /* ABSL_GUARDED_BY(mutex_) */ =
-      2 << 20;  // Default: 2 Mbps.
+  bool needs_key_frame_ = true;
+  int target_bitrate_ = 2 << 20;  // Default: 2 Mbps.
 
   // The queue of frame encodes. The size of this queue is implicitly bounded by
   // EncodeAndSend(), where it checks for the total in-flight media duration and
   // maybe drops a frame.
-  std::queue<WorkUnit> encode_queue_;  // ABSL_GUARDED_BY(mutex_)
+  std::queue<WorkUnit> encode_queue_;
 
   // Current VP8 encoder configuration. Most of the fields are unchanging, and
   // are populated in the ctor; but thereafter, only the encode thread accesses