Skip to content

Commit e0e53da

Browse files
committed
Merge branch 'ddalcino-fix-bounds-check-ch1.5'
2 parents 48fe3d5 + 8830b9d commit e0e53da

68 files changed

Lines changed: 70 additions & 70 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

book/src/chapter_22.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -430,7 +430,7 @@ impl<'a> System<'a> for VisibilitySystem {
430430
if viewshed.dirty {
431431
viewshed.dirty = false;
432432
viewshed.visible_tiles = field_of_view(Point::new(pos.x, pos.y), viewshed.range, &*map);
433-
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width-1 && p.y >= 0 && p.y < map.height-1 );
433+
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width && p.y >= 0 && p.y < map.height );
434434

435435
// If this is the player, reveal what they can see
436436
let _p : Option<&Player> = player.get(ent);

book/src/chapter_5.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ impl<'a> System<'a> for VisibilitySystem {
247247
for (viewshed,pos) in (&mut viewshed, &pos).join() {
248248
viewshed.visible_tiles.clear();
249249
viewshed.visible_tiles = field_of_view(Point::new(pos.x, pos.y), viewshed.range, &*map);
250-
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width-1 && p.y >= 0 && p.y < map.height-1 );
250+
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width && p.y >= 0 && p.y < map.height );
251251
}
252252
}
253253
}
@@ -386,7 +386,7 @@ impl<'a> System<'a> for VisibilitySystem {
386386
for (ent,viewshed,pos) in (&entities, &mut viewshed, &pos).join() {
387387
viewshed.visible_tiles.clear();
388388
viewshed.visible_tiles = field_of_view(Point::new(pos.x, pos.y), viewshed.range, &*map);
389-
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width-1 && p.y >= 0 && p.y < map.height-1 );
389+
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width && p.y >= 0 && p.y < map.height );
390390

391391
// If this is the player, reveal what they can see
392392
let p : Option<&Player> = player.get(ent);
@@ -468,7 +468,7 @@ if viewshed.dirty {
468468
viewshed.dirty = false;
469469
viewshed.visible_tiles.clear();
470470
viewshed.visible_tiles = field_of_view(Point::new(pos.x, pos.y), viewshed.range, &*map);
471-
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width-1 && p.y >= 0 && p.y < map.height-1 );
471+
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width && p.y >= 0 && p.y < map.height );
472472

473473
// If this is the player, reveal what they can see
474474
let _p : Option<&Player> = player.get(ent);

chapter-05-fov/src/visibility_system.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ impl<'a> System<'a> for VisibilitySystem {
1919
viewshed.dirty = false;
2020
viewshed.visible_tiles.clear();
2121
viewshed.visible_tiles = field_of_view(Point::new(pos.x, pos.y), viewshed.range, &*map);
22-
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width-1 && p.y >= 0 && p.y < map.height-1 );
22+
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width && p.y >= 0 && p.y < map.height );
2323

2424
// If this is the player, reveal what they can see
2525
let _p : Option<&Player> = player.get(ent);

chapter-06-monsters/src/visibility_system.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ impl<'a> System<'a> for VisibilitySystem {
1818
if viewshed.dirty {
1919
viewshed.dirty = false;
2020
viewshed.visible_tiles = field_of_view(Point::new(pos.x, pos.y), viewshed.range, &*map);
21-
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width-1 && p.y >= 0 && p.y < map.height-1 );
21+
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width && p.y >= 0 && p.y < map.height );
2222

2323
// If this is the player, reveal what they can see
2424
let _p : Option<&Player> = player.get(ent);

chapter-07-damage/src/visibility_system.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ impl<'a> System<'a> for VisibilitySystem {
1818
if viewshed.dirty {
1919
viewshed.dirty = false;
2020
viewshed.visible_tiles = field_of_view(Point::new(pos.x, pos.y), viewshed.range, &*map);
21-
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width-1 && p.y >= 0 && p.y < map.height-1 );
21+
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width && p.y >= 0 && p.y < map.height );
2222

2323
// If this is the player, reveal what they can see
2424
let _p : Option<&Player> = player.get(ent);

chapter-08-ui/src/visibility_system.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ impl<'a> System<'a> for VisibilitySystem {
1818
if viewshed.dirty {
1919
viewshed.dirty = false;
2020
viewshed.visible_tiles = field_of_view(Point::new(pos.x, pos.y), viewshed.range, &*map);
21-
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width-1 && p.y >= 0 && p.y < map.height-1 );
21+
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width && p.y >= 0 && p.y < map.height );
2222

2323
// If this is the player, reveal what they can see
2424
let _p : Option<&Player> = player.get(ent);

chapter-09-items/src/visibility_system.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ impl<'a> System<'a> for VisibilitySystem {
1818
if viewshed.dirty {
1919
viewshed.dirty = false;
2020
viewshed.visible_tiles = field_of_view(Point::new(pos.x, pos.y), viewshed.range, &*map);
21-
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width-1 && p.y >= 0 && p.y < map.height-1 );
21+
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width && p.y >= 0 && p.y < map.height );
2222

2323
// If this is the player, reveal what they can see
2424
let _p : Option<&Player> = player.get(ent);

chapter-10-ranged/src/visibility_system.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ impl<'a> System<'a> for VisibilitySystem {
1818
if viewshed.dirty {
1919
viewshed.dirty = false;
2020
viewshed.visible_tiles = field_of_view(Point::new(pos.x, pos.y), viewshed.range, &*map);
21-
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width-1 && p.y >= 0 && p.y < map.height-1 );
21+
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width && p.y >= 0 && p.y < map.height );
2222

2323
// If this is the player, reveal what they can see
2424
let _p : Option<&Player> = player.get(ent);

chapter-11-loadsave/src/visibility_system.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ impl<'a> System<'a> for VisibilitySystem {
1818
if viewshed.dirty {
1919
viewshed.dirty = false;
2020
viewshed.visible_tiles = field_of_view(Point::new(pos.x, pos.y), viewshed.range, &*map);
21-
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width-1 && p.y >= 0 && p.y < map.height-1 );
21+
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width && p.y >= 0 && p.y < map.height );
2222

2323
// If this is the player, reveal what they can see
2424
let _p : Option<&Player> = player.get(ent);

chapter-12-delvingdeeper/src/visibility_system.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ impl<'a> System<'a> for VisibilitySystem {
1818
if viewshed.dirty {
1919
viewshed.dirty = false;
2020
viewshed.visible_tiles = field_of_view(Point::new(pos.x, pos.y), viewshed.range, &*map);
21-
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width-1 && p.y >= 0 && p.y < map.height-1 );
21+
viewshed.visible_tiles.retain(|p| p.x >= 0 && p.x < map.width && p.y >= 0 && p.y < map.height );
2222

2323
// If this is the player, reveal what they can see
2424
let _p : Option<&Player> = player.get(ent);

0 commit comments

Comments
 (0)