Remove cleanup()

Leftover from when watchers were checked after each test.

Author: trowski

src/AsyncTestCase.php

@@ -37,14 +37,6 @@ final public function setName(string $name): void
         $this->realTestName = $name;
     }
 
-    /**
-     * Execute any needed cleanup after the test before loop watchers are checked.
-     */
-    protected function cleanup(): void
-    {
-        // Empty method in base class.
-    }
-
     protected function setUp(): void
     {
         $this->setUpInvoked = true;
@@ -75,33 +67,29 @@ final protected function runAsyncTest(mixed ...$args): mixed
         $start = now();
 
         try {
-            try {
-                [, $returnValue] = all([
-                    $this->deferredFuture->getFuture(),
-                    async(function () use ($args): mixed {
-                        try {
-                            $result = ([$this, $this->realTestName])(...$args);
-                            if ($result instanceof Future) {
-                                $result = $result->await();
-                            }
-
-                            // Force an extra tick of the event loop to ensure any uncaught exceptions are
-                            // forwarded to the event loop handler before the test ends.
-                            $deferred = new DeferredFuture();
-                            EventLoop::defer(static fn () => $deferred->complete());
-                            $deferred->getFuture()->await();
-
-                            return $result;
-                        } finally {
-                            if (!$this->deferredFuture->isComplete()) {
-                                $this->deferredFuture->complete();
-                            }
+            [, $returnValue] = all([
+                $this->deferredFuture->getFuture(),
+                async(function () use ($args): mixed {
+                    try {
+                        $result = ([$this, $this->realTestName])(...$args);
+                        if ($result instanceof Future) {
+                            $result = $result->await();
                         }
-                    }),
-                ]);
-            } finally {
-                $this->cleanup();
-            }
+
+                        // Force an extra tick of the event loop to ensure any uncaught exceptions are
+                        // forwarded to the event loop handler before the test ends.
+                        $deferred = new DeferredFuture();
+                        EventLoop::defer(static fn () => $deferred->complete());
+                        $deferred->getFuture()->await();
+
+                        return $result;
+                    } finally {
+                        if (!$this->deferredFuture->isComplete()) {
+                            $this->deferredFuture->complete();
+                        }
+                    }
+                }),
+            ]);
         } finally {
             if (isset($this->timeoutId)) {
                 EventLoop::cancel($this->timeoutId);

test/AsyncTestCaseTest.php

@@ -15,17 +15,6 @@
 
 class AsyncTestCaseTest extends AsyncTestCase
 {
-    public function cleanup(): void
-    {
-        parent::cleanup();
-
-        if ($this->getName() === 'testCleanupInvoked') {
-            $exception = new TestException;
-            $this->expectExceptionObject($exception);
-            throw $exception;
-        }
-    }
-
     public function testThatMethodRunsInEventLoopContext(): Future
     {
         $returnDeferred = new DeferredFuture; // make sure our test runs to completion
@@ -192,9 +181,4 @@ public function testThrowToEventLoop(): void
 
         (new DeferredFuture)->getFuture()->await();
     }
-
-    public function testCleanupInvoked(): void
-    {
-        // Exception thrown in cleanup() to assert method is invoked.
-    }
 }