create destination dir only when neccessary in AbstractProvider

Author: andreaskueffel

FileSyncLibNet/SyncProviders/AbstractProvider.cs

@@ -19,7 +19,7 @@ public AbstractProvider(IFileJobOptions jobOptions) : base(jobOptions)
             if (syncJobOptions.SourcePath.StartsWith("scp:"))
             {
                 SourceAccess = new ScpAccessProvider(syncJobOptions.Credentials);
-                
+
             }
             else
             {
@@ -34,7 +34,7 @@ public AbstractProvider(IFileJobOptions jobOptions) : base(jobOptions)
             {
                 DestinationAccess = new FileIoAccessProvider();
             }
-            
+
         }
 
         public override void DeleteFiles()
@@ -47,31 +47,40 @@ public override void SyncSourceToDest()
             if (!(JobOptions is IFileSyncJobOptions jobOptions))
                 throw new ArgumentException("this instance has no information about syncing files, it has type " + JobOptions.GetType().ToString());
             var sw = Stopwatch.StartNew();
+
             try
             {
                 string formattedDestinationPath = string.Format(jobOptions.DestinationPath, DateTime.Now);
                 DestinationAccess.UpdateAccessPath(formattedDestinationPath);
-                DestinationAccess.CreateDirectory("");
             }
-            catch (Exception ex) { logger?.LogError(ex, "exception creating destination directory {A}", jobOptions.DestinationPath); }
-            if (JobOptions.Credentials != null)
-            {
+            catch (Exception ex) { logger?.LogError(ex, "exception formatting destination accesspath with DateTime.Now as 0 arg {A}", jobOptions.DestinationPath); }
 
-            }
+            bool createDestinationDir = true;
             int copied = 0;
             int skipped = 0;
             var minimumLastWriteTime = jobOptions.RememberLastSync ? (LastRun - jobOptions.Interval - jobOptions.Interval) : DateTime.MinValue;
             bool error_occured = false;
             try
             {
-                var sourceFiles = SourceAccess.GetFiles(minimumLastWriteTime.DateTime, JobOptions.SearchPattern, recursive: JobOptions.Recursive, subfolders: JobOptions.Subfolders);
-
+                var sourceFiles = SourceAccess.GetFiles(minimumLastWriteTime: minimumLastWriteTime.DateTime,
+                                                        pattern: JobOptions.SearchPattern,
+                                                        recursive: JobOptions.Recursive,
+                                                        subfolders: JobOptions.Subfolders);
                 foreach (var sourceFile in sourceFiles)
                 {
                     var remoteFile = DestinationAccess.GetFileInfo(sourceFile.Name);
                     bool copy = !remoteFile.Exists || remoteFile.Length != sourceFile.Length || remoteFile.LastWriteTime != sourceFile.LastWriteTime;
                     if (copy)
                     {
+                        if (createDestinationDir)
+                        {
+                            try
+                            {
+                                DestinationAccess.CreateDirectory("");
+                            }
+                            catch (Exception ex) { logger?.LogError(ex, "exception creating destination directory {A}", jobOptions.DestinationPath); }
+                            createDestinationDir = false;
+                        }
                         try
                         {
                             logger.LogDebug("Copy {A}", sourceFile.Name);
@@ -105,7 +114,7 @@ public override void SyncSourceToDest()
                     LastRun = DateTimeOffset.Now;
                 }
             }
-            catch(Exception exc)
+            catch (Exception exc)
             {
                 logger.LogError(exc, "Exception in main logic of abstract provider");
             }