Skip to content

Commit 4d9b2b6

Browse files
andy-shevgregkh
authored andcommitted
gpiolib: Fix crash on error in gpiochip_get_ngpios()
[ Upstream commit 7b4aebe ] The gpiochip_get_ngpios() uses chip_*() macros to print messages. However these macros rely on gpiodev to be initialised and set, which is not the case when called via bgpio_init(). In such a case the printing messages will crash on NULL pointer dereference. Replace chip_*() macros by the respective dev_*() ones to avoid such crash. Fixes: 55b2395 ("gpio: mmio: handle "ngpios" properly in bgpio_init()") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20250213155646.2882324-1-andriy.shevchenko@linux.intel.com Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 99ca540 commit 4d9b2b6

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/gpio/gpiolib.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -723,13 +723,13 @@ int gpiochip_get_ngpios(struct gpio_chip *gc, struct device *dev)
723723
}
724724

725725
if (gc->ngpio == 0) {
726-
chip_err(gc, "tried to insert a GPIO chip with zero lines\n");
726+
dev_err(dev, "tried to insert a GPIO chip with zero lines\n");
727727
return -EINVAL;
728728
}
729729

730730
if (gc->ngpio > FASTPATH_NGPIO)
731-
chip_warn(gc, "line cnt %u is greater than fast path cnt %u\n",
732-
gc->ngpio, FASTPATH_NGPIO);
731+
dev_warn(dev, "line cnt %u is greater than fast path cnt %u\n",
732+
gc->ngpio, FASTPATH_NGPIO);
733733

734734
return 0;
735735
}

0 commit comments

Comments
 (0)