Skip to content

Commit a623d31

Browse files
keithbuschgregkh
authored andcommitted
block: make BLK_DEF_MAX_SECTORS unsigned
[ Upstream commit 0a26f32 ] This is used as an unsigned value, so define it that way to avoid having to cast it. Suggested-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Keith Busch <kbusch@kernel.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> Link: https://lore.kernel.org/r/20230105205146.3610282-2-kbusch@meta.com Signed-off-by: Jens Axboe <axboe@kernel.dk> Stable-dep-of: 9a9525d ("null_blk: don't cap max_hw_sectors to BLK_DEF_MAX_SECTORS") Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 33f93ce commit a623d31

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

block/blk-settings.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ void blk_queue_max_hw_sectors(struct request_queue *q, unsigned int max_hw_secto
135135
limits->max_hw_sectors = max_hw_sectors;
136136

137137
max_sectors = min_not_zero(max_hw_sectors, limits->max_dev_sectors);
138-
max_sectors = min_t(unsigned int, max_sectors, BLK_DEF_MAX_SECTORS);
138+
max_sectors = min(max_sectors, BLK_DEF_MAX_SECTORS);
139139
max_sectors = round_down(max_sectors,
140140
limits->logical_block_size >> SECTOR_SHIFT);
141141
limits->max_sectors = max_sectors;

drivers/block/null_blk/main.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2116,8 +2116,7 @@ static int null_add_dev(struct nullb_device *dev)
21162116
blk_queue_physical_block_size(nullb->q, dev->blocksize);
21172117
if (!dev->max_sectors)
21182118
dev->max_sectors = queue_max_hw_sectors(nullb->q);
2119-
dev->max_sectors = min_t(unsigned int, dev->max_sectors,
2120-
BLK_DEF_MAX_SECTORS);
2119+
dev->max_sectors = min(dev->max_sectors, BLK_DEF_MAX_SECTORS);
21212120
blk_queue_max_hw_sectors(nullb->q, dev->max_sectors);
21222121

21232122
if (dev->virt_boundary)

include/linux/blkdev.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1109,11 +1109,12 @@ static inline bool bdev_is_partition(struct block_device *bdev)
11091109
enum blk_default_limits {
11101110
BLK_MAX_SEGMENTS = 128,
11111111
BLK_SAFE_MAX_SECTORS = 255,
1112-
BLK_DEF_MAX_SECTORS = 2560,
11131112
BLK_MAX_SEGMENT_SIZE = 65536,
11141113
BLK_SEG_BOUNDARY_MASK = 0xFFFFFFFFUL,
11151114
};
11161115

1116+
#define BLK_DEF_MAX_SECTORS 2560u
1117+
11171118
static inline unsigned long queue_segment_boundary(const struct request_queue *q)
11181119
{
11191120
return q->limits.seg_boundary_mask;

0 commit comments

Comments
 (0)