Skip to content
This repository was archived by the owner on May 28, 2021. It is now read-only.

Commit 43eaf04

Browse files
changbindugregkh
authored andcommitted
perf top: Fix error handling in cmd_top()
[ Upstream commit 70c819e4bf1c5f492768b399d898d458ccdad2b6 ] We should go to the cleanup path, to avoid leaks, detected using gcc's ASan. Signed-off-by: Changbin Du <changbin.du@gmail.com> Reviewed-by: Jiri Olsa <jolsa@kernel.org> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Steven Rostedt (VMware) <rostedt@goodmis.org> Link: http://lkml.kernel.org/r/20190316080556.3075-9-changbin.du@gmail.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 742007f commit 43eaf04

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

tools/perf/builtin-top.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1256,8 +1256,9 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
12561256
symbol_conf.priv_size = sizeof(struct annotation);
12571257

12581258
symbol_conf.try_vmlinux_path = (symbol_conf.vmlinux_name == NULL);
1259-
if (symbol__init(NULL) < 0)
1260-
return -1;
1259+
status = symbol__init(NULL);
1260+
if (status < 0)
1261+
goto out_delete_evlist;
12611262

12621263
sort__setup_elide(stdout);
12631264

0 commit comments

Comments
 (0)