fix(@angular-devkit/build-angular): avoid ES module assumption for vendor files

clydin · filipesilva · commit 411fe21f1cef · 2020-07-20T11:57:22.000+01:00
This change prevents import statements from being added to commonjs files when downleveling helpers are needed. These imports would then cause webpack to assume that the file is an ES module and potentially break the commonjs file. Fixes #18284
diff --git a/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts b/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts
@@ -544,6 +544,7 @@ export function getCommonConfig(wco: WebpackConfigOptions): Configuration {
                       cacheIdentifier: JSON.stringify({
                         buildAngular: require('../../../../package.json').version,
                       }),
+                      sourceType: 'unambiguous',
                       presets: [
                         [
                           require.resolve('@babel/preset-env'),

Original file line number	Diff line number	Diff line change
`@@ -544,6 +544,7 @@ export function getCommonConfig(wco: WebpackConfigOptions): Configuration {`
`544`	`544`	`cacheIdentifier: JSON.stringify({`
`545`	`545`	`buildAngular: require('../../../../package.json').version,`
`546`	`546`	`}),`
	`547`	`+ sourceType: 'unambiguous',`
`547`	`548`	`presets: [`
`548`	`549`	`[`
`549`	`550`	`require.resolve('@babel/preset-env'),`