Skip to content

Commit 59c8a2f

Browse files
refactor(schematics): derive the firebase-tools version message from a shared constant (#3704)
The minimum-version check and its error message were separate string literals. They drifted once before (the message read "13.0.0+" while the check required 14.0.0). A single minFirebaseToolsVersion constant, with the message built from it, keeps the two in sync.
1 parent 45f138d commit 59c8a2f

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

src/schematics/firebaseTools.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ declare global {
88
var firebaseTools: FirebaseTools|undefined;
99
}
1010

11+
// The minimum firebase-tools version the schematics require.
12+
const minFirebaseToolsVersion = '14.0.0';
13+
1114
export const getFirebaseTools = () => globalThis.firebaseTools ?
1215
Promise.resolve(globalThis.firebaseTools) :
1316
new Promise<FirebaseTools>((resolve, reject) => {
@@ -44,8 +47,8 @@ export const getFirebaseTools = () => globalThis.firebaseTools ?
4447
globalThis.firebaseTools = firebaseTools;
4548
const version = firebaseTools.cli.version();
4649
console.log(`Using firebase-tools version ${version}`);
47-
if (semverCompare(version, '14.0.0') === -1) {
48-
console.error('firebase-tools version 14.0.0+ is required, please upgrade and run again');
50+
if (semverCompare(version, minFirebaseToolsVersion) === -1) {
51+
console.error(`firebase-tools version ${minFirebaseToolsVersion}+ is required, please upgrade and run again`);
4952
return Promise.reject();
5053
}
5154
return firebaseTools;

0 commit comments

Comments
 (0)