Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Commit 7acfed8

Browse files
authored
Turn off enum_alias test by removing enum annotation. (#863)
The current emit is wrong - self circular. Closure team wants to land a change that changes it into another (also wrong emit), turn off test to unblock that. #862 to track proper fix.
1 parent 833ae16 commit 7acfed8

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

src/test/java/com/google/javascript/clutz/partial/enum_alias.d.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
declare namespace ಠ_ಠ.clutz {
2-
type module$exports$enum_alias = ಠ_ಠ.clutz.module$exports$enum_alias ;
3-
let module$exports$enum_alias : typeof ಠ_ಠ.clutz.module$exports$enum_alias ;
2+
//!! Closure will begin emitting this soon:
3+
//!! enum module$exports$enum_alias { }
4+
//!!
5+
//!! That is incorrect, wait until closure starts emitting it
6+
//!! at head and then reenable the test and fix properly.
7+
//!! https://github.com/angular/clutz/issues/862
8+
let module$exports$enum_alias : any ;
49
}
510
declare module 'goog:enum_alias' {
611
import enum_alias = ಠ_ಠ.clutz.module$exports$enum_alias;

src/test/java/com/google/javascript/clutz/partial/enum_alias.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@ goog.module('enum_alias');
22

33
const OtherEnum = goog.require('not_visible');
44

5-
/** @enum {string} */
5+
//!! This test is temporary turned off to enable
6+
//!! change in behavior on closure side.
7+
//!! /** @enum {string} */
68
const Enum = OtherEnum;
79

810
exports = Enum;

0 commit comments

Comments
 (0)