fix(binaries): filter m1 mac chromedriver versions (#478)

Fixes #476

Author: jimivdw

lib/binaries/chrome_xml.ts

@@ -32,9 +32,11 @@ export class ChromeXml extends XmlConfigSource {
       for (let content of xml.ListBucketResult.Contents) {
         let contentKey: string = content.Key[0];
 
-
-        // Filter for 32-bit devices, make sure x64 is not an option
-        if (this.osarch === 'x64' || !contentKey.includes('64')) {
+        if (
+            // Filter for 32-bit devices, make sure x64 is not an option
+            (this.osarch.includes('64') || !contentKey.includes('64')) &&
+            // Filter for x86 macs, make sure m1 is not an option
+            ((this.ostype === 'Darwin' && this.osarch === 'arm64') || !contentKey.includes('m1'))) {
           // Filter for only the osType
           if (contentKey.includes(osType)) {
             versionPaths.push(contentKey);
@@ -95,7 +97,9 @@ export class ChromeXml extends XmlConfigSource {
                     (this.osarch !== 'x64' && !item.includes(this.getOsTypeName() + '64'))) {
                   itemFound = item;
                 }
-
+                if (this.osarch === 'arm64' && this.ostype === 'Darwin' && item.includes('m1')) {
+                  itemFound = item;
+                }
               }
               // If the semantic version is the same, check os arch.
               // For 64-bit systems, prefer the 64-bit version.

spec/binaries/chrome_xml_spec.ts

@@ -17,6 +17,7 @@ describe('chrome xml reader', () => {
     chromeXml.getVersionList().then(list => {
       for (let item of list) {
         expect(item).toContain('/chromedriver_mac');
+        expect(item).not.toContain('m1');
       }
       done();
     });
@@ -65,4 +66,15 @@ describe('chrome xml reader', () => {
       done();
     });
   });
+
+  it('should get the 87.0.4280.88, 64-bit, m1 version (arch = arm64)', (done) => {
+    let chromeXml = new ChromeXml();
+    chromeXml.out_dir = out_dir;
+    chromeXml.ostype = 'Darwin';
+    chromeXml.osarch = 'arm64';
+    chromeXml.getUrl('87.0.4280.88').then((binaryUrl) => {
+      expect(binaryUrl.url).toContain('87.0.4280.88/chromedriver_mac64_m1.zip');
+      done();
+    });
+  });
 });