feat(card-browser): add icons for non-multiselect options

Author: david-allison

AnkiDroid/src/main/java/com/ichi2/anki/browser/CardBrowserFragment.kt

@@ -38,6 +38,7 @@ import android.widget.TextView
 import androidx.annotation.CheckResult
 import androidx.annotation.LayoutRes
 import androidx.annotation.VisibleForTesting
+import androidx.appcompat.view.menu.MenuBuilder
 import androidx.appcompat.widget.ThemeUtils
 import androidx.core.content.ContextCompat
 import androidx.core.graphics.drawable.DrawableCompat
@@ -762,6 +763,11 @@ class CardBrowserFragment :
         menuHost.addPrepareMenuProvider { menu ->
             if (!useSearchView) return@addPrepareMenuProvider
 
+            // icons have been added for all 'unselected' items
+            if (!activityViewModel.isInMultiSelectMode) {
+                (menu as? MenuBuilder)?.setOptionalIconsVisible(true)
+            }
+
             // reorder 'preview' to appear before 'add'
             val preview = menu.findItem(R.id.action_preview_many)
             if (activityViewModel.cards.size > 0) {

AnkiDroid/src/main/res/drawable/ic_add_filtered_deck.xml

@@ -2,7 +2,8 @@
     android:width="24dp"
     android:height="24dp"
     android:viewportWidth="24"
-    android:viewportHeight="24">
+    android:viewportHeight="24"
+    android:tint="?attr/colorControlNormal">
     <path
         android:pathData="M3.1992,3.9688C2.0992,3.9688 1.1992,4.8688 1.1992,5.9688L1.1992,13.9688C1.1992,15.0688 2.0992,15.9688 3.1992,15.9688L17.1992,15.9688C18.2992,15.9688 19.1992,15.0688 19.1992,13.9688L19.1992,5.9688C19.1992,4.8688 18.2992,3.9688 17.1992,3.9688L3.1992,3.9688zM5.9395,6.0488L7.9395,6.0488zM21.1992,6.9688L21.1992,17.9688L4.1992,17.9688L4.1992,17.9844A1.9846,1.9846 0,0 0,6.1836 19.9688L21.1992,19.9688C22.2992,19.9688 23.1992,19.0688 23.1992,17.9688L23.1992,8.9531A1.9846,1.9846 0,0 0,21.2148 6.9688L21.1992,6.9688z M3,6H12V8H3 M4,9H11V11H4 M5,12H10V14H5"
         android:fillColor="#ffffff"/>

AnkiDroid/src/main/res/menu/card_browser.xml

@@ -58,15 +58,18 @@
 
     <item
         android:id="@+id/action_select_all"
+        android:icon="@drawable/ic_select_all_white"
         android:title="@string/card_browser_select_all"/>
 
     <item
         android:id="@+id/action_open_options"
+        android:icon="@drawable/ic_settings_black"
         android:title="@string/study_options"
         ankidroid:showAsAction="never"/>
 
     <item
         android:id="@+id/action_create_filtered_deck"
+        android:icon="@drawable/ic_add_filtered_deck"
         ankidroid:showAsAction="never"
         tools:title="Create filtered deck..."
         />