Skip to content

Commit b00a1d6

Browse files
committed
fix(card-browser): hide 'preview' if no notes
1 parent 3ed52b4 commit b00a1d6

2 files changed

Lines changed: 35 additions & 0 deletions

File tree

AnkiDroid/src/main/java/com/ichi2/anki/browser/CardBrowserFragment.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -490,6 +490,9 @@ class CardBrowserFragment :
490490
menu.findItem(R.id.action_select_all)?.isVisible =
491491
vm.rowCount > 0 && vm.selectedRowCount() < vm.rowCount
492492

493+
menu.findItem(R.id.action_preview_many)?.isVisible =
494+
vm.rowCount > 0
495+
493496
menu.findItem(R.id.action_undo).setupUndo()
494497
}
495498

AnkiDroid/src/test/java/com/ichi2/anki/CardBrowserTest.kt

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1724,6 +1724,38 @@ class CardBrowserTest : RobolectricTest() {
17241724
assertMenusEqual(expectedMenuItems, menu)
17251725
}
17261726

1727+
@Test
1728+
fun `options menu - new ui - no notes`() =
1729+
withOptionsMenu(
1730+
OptionsMenuType(
1731+
fragmented = false,
1732+
mutliselect = false,
1733+
newUi = true,
1734+
),
1735+
noteCount = 0,
1736+
) {
1737+
val expectedMenuItems =
1738+
listOf(
1739+
R.id.action_add_note_from_card_browser to true,
1740+
R.id.action_search to false,
1741+
R.id.action_save_search to false,
1742+
R.id.action_list_my_searches to false,
1743+
R.id.action_sort_by_size to false,
1744+
R.id.action_show_marked to false,
1745+
R.id.action_show_suspended to false,
1746+
R.id.action_search_by_tag to false,
1747+
R.id.action_search_by_flag to false,
1748+
R.id.action_undo to false,
1749+
R.id.action_preview_many to false,
1750+
R.id.action_select_all to false,
1751+
R.id.action_open_options to true,
1752+
R.id.action_create_filtered_deck to true,
1753+
R.id.action_find_replace to false,
1754+
)
1755+
1756+
assertMenusEqual(expectedMenuItems, menu)
1757+
}
1758+
17271759
@Test
17281760
fun `options menu - new ui - add is first if no results`() =
17291761
withOptionsMenu(

0 commit comments

Comments
 (0)