refactor: migrate the preference code to use Fragment and remove usage of MyAccount activity

Author: criticalAY

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

@@ -97,6 +97,7 @@ import com.ichi2.anki.InitialActivity.StartupFailure.FutureAnkidroidVersion
 import com.ichi2.anki.InitialActivity.StartupFailure.SDCardNotMounted
 import com.ichi2.anki.InitialActivity.StartupFailure.WebviewFailed
 import com.ichi2.anki.IntentHandler.Companion.intentToReviewDeckFromShortcuts
+import com.ichi2.anki.account.AccountActivity
 import com.ichi2.anki.analytics.UsageAnalytics
 import com.ichi2.anki.android.back.exitViaDoubleTapBackCallback
 import com.ichi2.anki.android.input.ShortcutGroup
@@ -2107,7 +2108,7 @@ open class DeckPicker :
             return
         }
 
-        MyAccount.checkNotificationPermission(this, notificationPermissionLauncher)
+        AccountActivity.checkNotificationPermission(this, notificationPermissionLauncher)
 
         /** Nested function that makes the connection to
          * the sync server and starts syncing the data */
@@ -2130,9 +2131,8 @@ open class DeckPicker :
     }
 
     override fun loginToSyncServer() {
-        val myAccount = Intent(this, MyAccount::class.java)
-        myAccount.putExtra("notLoggedIn", true)
-        loginForSyncLauncher.launch(myAccount)
+        val intent = AccountActivity.getIntent(this, forResult = true)
+        loginForSyncLauncher.launch(intent)
     }
 
     // Callback to import a file -- adding it to existing collection

AnkiDroid/src/main/java/com/ichi2/anki/preferences/SyncSettingsFragment.kt

@@ -21,6 +21,7 @@ import com.google.android.material.snackbar.Snackbar
 import com.ichi2.anki.CollectionManager.TR
 import com.ichi2.anki.CollectionManager.withCol
 import com.ichi2.anki.R
+import com.ichi2.anki.account.AccountActivity
 import com.ichi2.anki.launchCatchingTask
 import com.ichi2.anki.settings.Prefs
 import com.ichi2.anki.snackbar.showSnackbar
@@ -61,6 +62,15 @@ class SyncSettingsFragment : SettingsFragment() {
                 false
             }
         }
+
+        requirePreference<Preference>(R.string.sync_account_key).apply {
+            setOnPreferenceClickListener {
+                val accountActivityIntent = AccountActivity.getIntent(requireContext())
+                startActivity(accountActivityIntent)
+                true
+            }
+        }
+
         // Custom sync server
         requirePreference<Preference>(R.string.custom_sync_server_key).setSummaryProvider {
             customSyncBase() ?: getString(R.string.custom_sync_server_summary_none_of_the_two_servers_used)

AnkiDroid/src/main/res/xml/preferences_sync.xml

@@ -25,10 +25,6 @@
         android:key="@string/sync_account_key"
         android:summary="@string/sync_account_summ_logged_out"
         android:title="@string/sync_account" >
-        <!--suppress AndroidDomInspection: @string/applicationId works -->
-        <intent
-            android:targetClass="com.ichi2.anki.MyAccount"
-            android:targetPackage="@string/applicationId" />
     </Preference>
     <ListPreference
         android:defaultValue="@string/sync_media_always_value"