Fix issue with moving temporary files (#178)

Fixing the temp file permission bug
Fixes #167
(originally proposed in #176)
Co-authored-by: mphemming <mphemming@live.co.uk>

Author: mhidas

aodntools/timeseries_products/aggregated_timeseries.py

@@ -210,8 +210,9 @@ def main_aggregator(files_to_agg, var_to_agg, site_code, input_dir='', output_di
     rejected_files = []
 
     # default name for temporary file. It will be renamed at the end
-    _, temp_outfile = tempfile.mkstemp(suffix='.nc', dir=output_dir)
-
+    fd, temp_outfile = tempfile.mkstemp(suffix='.nc', dir=output_dir)
+    os.close(fd)
+    
     ## check files and get total number of flattened obs
     n_obs_total = 0
     for file in files_to_agg:

aodntools/timeseries_products/velocity_aggregated_timeseries.py

@@ -71,8 +71,8 @@ def velocity_aggregated(files_to_agg, site_code, input_dir='', output_dir='./',
     bad_files = {}
 
     # default name for temporary file. It will be renamed at the end
-    _, temp_outfile = tempfile.mkstemp(suffix='.nc', dir=output_dir)
-
+    fd, temp_outfile = tempfile.mkstemp(suffix='.nc', dir=output_dir)
+    os.close(fd)
     ## check files and get total number of flattened obs
     n_obs_total = 0
     for file in files_to_agg:
@@ -237,6 +237,7 @@ def velocity_aggregated(files_to_agg, site_code, input_dir='', output_dir='./',
                             ("velocity-"+product_type),
                             ('END-'+ time_end_filename), 'C-' + current_utc_timestamp(DATESTAMP_FORMAT)]) + '.nc'
     ncout_path = os.path.join(output_dir, output_name)
+
     shutil.move(temp_outfile, ncout_path)
 
 

aodntools/timeseries_products/velocity_hourly_timeseries.py

@@ -105,8 +105,8 @@ def velocity_hourly_aggregated(files_to_agg, site_code, input_dir='', output_dir
     chunk_size = 90  ## size in days
 
     ## default name for temporary file. It will be renamed at the end
-    _, temp_outfile = tempfile.mkstemp(suffix='.nc', dir=output_dir)
-
+    fd, temp_outfile = tempfile.mkstemp(suffix='.nc', dir=output_dir)
+    os.close(fd)
     ## check files and get total number of flattened obs
     print("CHECKING FILES...")
     for index, file in enumerate(files_to_agg):